Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor *ServiceMigrator and *SchemaRegistry classes by extracting common logic #16468

Open
imalygin opened this issue Nov 6, 2024 · 0 comments
Assignees
Labels
Platform Tickets pertaining to the platform Tech Debt Reduced Issues which reduce technical debt.

Comments

@imalygin
Copy link
Member

imalygin commented Nov 6, 2024

@tinker-michaelj suggested the following idea as a follow-up for #16379 :

it would be nice at some point if we could extract the common logic between the OrderedServiceMigrator/MerkleSchemaRegistry and FakeServiceMigrator/FakeSchemaRegistry types and reduce duplication between the subprocess and embedded Hedera state lifecycles.

That is, the idea is to consider OrderedServiceMigrator / FakeServiceMigrator and MerkleSchemaRegistry / FakeSchemaRegistry pairs, extract common logic to a class that resides in swirlds-state-impl. This will help to reduce the logic duplication

@poulok poulok added the Platform Tickets pertaining to the platform label Nov 12, 2024
@imalygin imalygin self-assigned this Jan 6, 2025
@poulok poulok added the Tech Debt Reduced Issues which reduce technical debt. label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Tickets pertaining to the platform Tech Debt Reduced Issues which reduce technical debt.
Projects
None yet
Development

No branches or pull requests

2 participants