Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hannah gf radiation update revert aerosols dom 20210823 #1

Conversation

climbfuji
Copy link

@hannahcbarnes I combined your code changes with mine, please see my suggested edits here. If ok, please merge and your PR will be updated automatically. I got b4b identical results in short test runs with GNU on Hera so far. Thanks!

Copy link
Owner

@hannahcbarnes hannahcbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me. Thanks!

@climbfuji
Copy link
Author

Thanks! Please press the merge button, I don't have write permission to your fork (for good reasons).

@hannahcbarnes hannahcbarnes merged commit 2069121 into hannahcbarnes:GF_RadiationUpdate_RevertAerosols Aug 23, 2021
hannahcbarnes pushed a commit that referenced this pull request Oct 14, 2021
Merge "Bugfix in Thompson MP, pass correct timestep to core routine" into "Adding inner loop to Thompson microphysics"
hannahcbarnes pushed a commit that referenced this pull request Mar 4, 2022
…te_from_main_20211119

Update gthompsnWRF:new_thompson_cloud_fraction with the latest code from NCAR ccpp-physics main
hannahcbarnes pushed a commit that referenced this pull request Mar 8, 2022
@climbfuji climbfuji deleted the hannah_GF_RadiationUpdate_RevertAerosols_dom_20210823 branch June 27, 2022 03:16
hannahcbarnes added a commit that referenced this pull request Aug 3, 2022
Update submodule pointer for ccpp/physics
hannahcbarnes pushed a commit that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants