You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This isn't #1391 but it does have some overlap. The work done towards resolving that issue only permits functionality when uglify-js isn't available.
This issue here is related to how NPM treats optional dependencies. Namely, it treats them as dependencies that the package can work without, but would like to have if possible (e.g. chokidar has an optional dependency on fsevents to permit better file system event handling on unix systems).
To make uglify-js truly optional, it should be a peerDependency. This expresses compatibility without having it automatically installed, leaving the dependency up to whoever uses handlebars.
Happy to make a PR for this (including any updates that would be needed for testing, etc) if people are happy with the proposed change.
The text was updated successfully, but these errors were encountered:
This isn't #1391 but it does have some overlap. The work done towards resolving that issue only permits functionality when
uglify-js
isn't available.This issue here is related to how NPM treats optional dependencies. Namely, it treats them as dependencies that the package can work without, but would like to have if possible (e.g.
chokidar
has an optional dependency onfsevents
to permit better file system event handling on unix systems).To make
uglify-js
truly optional, it should be apeerDependency
. This expresses compatibility without having it automatically installed, leaving the dependency up to whoever uses handlebars.Happy to make a PR for this (including any updates that would be needed for testing, etc) if people are happy with the proposed change.
The text was updated successfully, but these errors were encountered: