-
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slide Notes timer doesn't work #1922
Comments
I'm seeing the same issue. This bug appears to have crept in in commit 715cf0b. |
Took a while but I found out how to reproduce that error. It happens when you press the 'S' to open the speaker view, and then go back to the main window and press the 'S' key again while the popup is still open in the background. It's not happening when first opening the speaker view in any browser that I've tested. Wasn't able to find a way to fix it yet though. |
To me it does happen the first time I press |
It happened for me the first time I pressed |
I'm pulling Reveal from a CDN and have run into this issue as of 3.5.0, due to a CORS issue for the slide timing stuff. Because Would it be possible to use the existing message-passing This issue doesn't appear when |
If I just |
@kuncevic, are you opening As per the documentation on speaker notes, notes only work from a web server. |
@seanho00 i c, thanks for pointing that out. I was using a |
I'm having the same issue: timer not working when pressing 's', either on Chrome and Safari. |
For me the following works with Firefox (for presentations served from a web server as well as with local files):
|
You're right, I got the same behavior on Firefox (for Mac). I could not replicate it on either Safari or Chrome, though: the timer is not working even the second time I open the window. Update: That was when reading from a local file, when I read a presentation served from a web server the timer works OK on the three browsers, the first time I open the speaker window. |
Closing since this isn't an issue as notes are meant to be run from a server for |
Why is that? EDIT: this seems to be fixed by this PR: #2104 ? |
This bug is still present. I can reproduce it e.g. on https://revealjs.com/ You may reconsider to open this issue again. |
I am having the same issue here. |
I tested revealjs.com again in Chrome canary/stable but the timer is working every time, except for the issue with pressing S while notes are already opened that I described above. #2104 looks like a good improvement to make the notes work locally. I've moved the timer bug when opening notes twice to a new issue #2229 |
I had the same issue, the timer didn't work for safari and chrome (whichever way I press "s"). Following the "full setup" from https://github.com/hakimel/reveal.js/ solved the issue. |
When I open the Slide Notes browser page (pressing
s
) the timer doesn't start. I'm using Chromium and I'm getting this error in the consolethis doesn't happen in the standard view. I'm using the latest git version with Chromium 59. I'm initializing the presentation like this:
The text was updated successfully, but these errors were encountered: