Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for enkf analysis steps when using t(tv) as a control vector variable for regional FV3 DA #12

Merged
merged 4 commits into from
Jun 14, 2021
Merged

Bug fix for enkf analysis steps when using t(tv) as a control vector variable for regional FV3 DA #12

merged 4 commits into from
Jun 14, 2021

Conversation

BinLiu-NOAA
Copy link

@BinLiu-NOAA BinLiu-NOAA commented Jun 13, 2021 •
edited
Loading

*Bug fix for EnKF analysis steps when using t (tv) as a control vector variable for regional FV3 DA.

Notes:

  • This PR addresses issue Problematic T fields from the EnKF mean step #13, which was reported by Jonathan Poterjoy (UMD).
  • And this bug should have affected all the EnKF steps (mean, update, recenter, etc.)
  • The bug fix is based on the diagnoses and discussions among @BinLiu-NOAA and @TingLei-NOAA (EMC), @XL-OU, Jonathan Poterjoy (UMD), Jason Sippel (HRD), etc.
  • Besides, whitespace and indentation clean-ups were made in src/enkf/gridio_fv3reg.f90.

@BinLiu-NOAA
*Bug fix for enkf_mean when using t(tv) as a control vector variable for
4789b64 
regional FV3 DA.
Note: The issue was reported by Jon (UMD). And the fix is based on the
diagnoses and discusions among Bin and Ting (EMC), Xu (OU), Jon (UMD), Jason
(HRD), etc.
@BinLiu-NOAA
Whitespace and indentation cleanups for src/enkf/gridio_fv3reg.f90.
4ba0629
@BinLiu-NOAA
*Provide a better fix to just re-calculate qworkvar3d after it being …
f05bea6 
…written so

that it can be used below for the tsen calculation if needed.
@BinLiu-NOAA BinLiu-NOAA force-pushed the feature/regional_enkf_mean_tvfix branch from 4b592b0 to f05bea6 Compare June 14, 2021 00:39
@BinLiu-NOAA BinLiu-NOAA self-assigned this Jun 14, 2021
@BinLiu-NOAA BinLiu-NOAA changed the title Bug fix for enkf mean when using t(tv) as a control vector variable for regional FV3 DA Bug fix for enkf analysis steps when using t(tv) as a control vector variable for regional FV3 DA Jun 14, 2021
TingLei-daprediction
TingLei-daprediction reviewed Jun 14, 2021
View reviewed changes
Copy link

@TingLei-daprediction TingLei-daprediction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great job for the author and collaborators for this fix.

@BinLiu-NOAA BinLiu-NOAA merged commit af7b978 into feature/regional_ensda Jun 14, 2021
@BinLiu-NOAA BinLiu-NOAA deleted the feature/regional_enkf_mean_tvfix branch June 14, 2021 13:12
@BinLiu-NOAA BinLiu-NOAA mentioned this pull request Jun 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingLei-daprediction TingLei-daprediction TingLei-daprediction left review comments

@TingLei-NOAA TingLei-NOAA Awaiting requested review from TingLei-NOAA

@XuLu-NOAA XuLu-NOAA Awaiting requested review from XuLu-NOAA

Assignees

@BinLiu-NOAA BinLiu-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BinLiu-NOAA @TingLei-daprediction