the fix for incorrect reference to fv3reg conversion subroutines in m… #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…od_fv3_loal.f90 and for a newer crtm lib to avoid GSI aborion running in debug mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running this regional_ensda branch for FV3-CAM tm06-coldstart hybrid DA, it was found the conversion subroutines like fv3_h_to_ll in "mod_fv3_lola.f90 was incorrectly used when the correct one should be , for example, fv3_h_to_ll_regular_grids in mod_fv3_lolgrid.f90. The incorrect use occurred in the subroutine called when fv3sar_bg_opt=1 ( on tm06 for tm06-coldstart exp for fv3-cam hybrid runs) and the newly merged gsi_fv3ncdf_write_fv3_dz subroutine. They should not have any impacts on HAFL's runs ( the problem would cause real time aborting rather than different results).
Another change is to use crtm/2.3.1 from Mike Lueken to avoid GSI abortion when running on debug mode.
The third ones are a couple of un-initialized variables in get_gefs_for_regional.f90. Li Bi already add those into the GSI EMC master. The changes in this branch is just to avoid getting those minor changes from that upstream master and confine the PR to between regional_ensda and regional_ensda_fix1.