-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable bshuf filter #3
Comments
It compiles ok - but then I get a runtime error when I try to use it:
I spent some time looking around in the source to see if I could figure out what might be causing the issue, but I haven't found it yet. |
Ok, I managed to track it down - I need to pass the "-sWASM_BIGINT" flag to the plugin build process, just like I do for h5wasm. Internally emscripten was creating a "legalized" version of the unpack function with 32-bit output, which doesn't match the expected signature After the change, the bshuf filter seems to build and function fine. |
Great! Thanks for the fix! |
Hi,
Thanks a lot for this package! 🎉 We love it for the h5web viewer!
I'm wondering what is the issue with the
bshuf
filter that is commented?I'm not familiar with webassembly, but by maintaining hdf5plugin, I'm getting used to compile those filter, so if there is anything that could help, let me know.
The text was updated successfully, but these errors were encountered: