From 1bf505638c35fbfb36f0675294c66d81e2dadd48 Mon Sep 17 00:00:00 2001 From: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Date: Mon, 3 Jul 2023 05:00:30 +0900 Subject: [PATCH 1/2] style: fix typos in PlotJuggler config files (#3618) Signed-off-by: Kenji Miyake --- .../config/controller_monitor.xml | 12 ++++++------ .../config/error_rqt_multiplot.xml | 2 +- ..._pursuit_lateral_controller_plotjuggler_debug.xml | 10 +++++----- .../config/plot_juggler_trajectory_follower.xml | 8 ++++---- .../config/plot_juggler_obstacle_cruise_planner.xml | 10 +++++----- .../config/plot_juggler_adaptive_cruise.xml | 8 ++++---- .../config/plot_juggler_slow_down.xml | 8 ++++---- .../config/planning_validator_plotjugler_config.xml | 10 +++++----- .../config/processing_time_ms.xml | 8 ++++---- 9 files changed, 38 insertions(+), 38 deletions(-) diff --git a/control/control_performance_analysis/config/controller_monitor.xml b/control/control_performance_analysis/config/controller_monitor.xml index c5189ccec4110..cb3f38e55e5f0 100644 --- a/control/control_performance_analysis/config/controller_monitor.xml +++ b/control/control_performance_analysis/config/controller_monitor.xml @@ -287,7 +287,7 @@ - + @@ -381,7 +381,7 @@ - + @@ -389,7 +389,7 @@ - + @@ -405,14 +405,14 @@ - + - + - + sum = 0 sum = sum + math.abs(value) diff --git a/control/control_performance_analysis/config/error_rqt_multiplot.xml b/control/control_performance_analysis/config/error_rqt_multiplot.xml index b80449fb9067e..8597cbdaa253e 100644 --- a/control/control_performance_analysis/config/error_rqt_multiplot.xml +++ b/control/control_performance_analysis/config/error_rqt_multiplot.xml @@ -726,7 +726,7 @@ true 30 - Measured and Computed Steerings Plot + Measured and Computed Steering Plot diff --git a/control/pure_pursuit/config/pure_pursuit_lateral_controller_plotjuggler_debug.xml b/control/pure_pursuit/config/pure_pursuit_lateral_controller_plotjuggler_debug.xml index 284380c654255..9e0fc652652c3 100644 --- a/control/pure_pursuit/config/pure_pursuit_lateral_controller_plotjuggler_debug.xml +++ b/control/pure_pursuit/config/pure_pursuit_lateral_controller_plotjuggler_debug.xml @@ -77,7 +77,7 @@ - + @@ -85,7 +85,7 @@ - + @@ -98,15 +98,15 @@ - + - + - + diff --git a/control/trajectory_follower_node/config/plot_juggler_trajectory_follower.xml b/control/trajectory_follower_node/config/plot_juggler_trajectory_follower.xml index 303ba94ddb399..6956db84aff56 100644 --- a/control/trajectory_follower_node/config/plot_juggler_trajectory_follower.xml +++ b/control/trajectory_follower_node/config/plot_juggler_trajectory_follower.xml @@ -243,13 +243,13 @@ - + - + @@ -263,11 +263,11 @@ - + - + diff --git a/planning/obstacle_cruise_planner/config/plot_juggler_obstacle_cruise_planner.xml b/planning/obstacle_cruise_planner/config/plot_juggler_obstacle_cruise_planner.xml index b1a5275feda37..75500da8d2d49 100644 --- a/planning/obstacle_cruise_planner/config/plot_juggler_obstacle_cruise_planner.xml +++ b/planning/obstacle_cruise_planner/config/plot_juggler_obstacle_cruise_planner.xml @@ -145,13 +145,13 @@ - + - + @@ -167,15 +167,15 @@ - + - + - + diff --git a/planning/obstacle_stop_planner/config/plot_juggler_adaptive_cruise.xml b/planning/obstacle_stop_planner/config/plot_juggler_adaptive_cruise.xml index 5770820fbba1d..b7c37e5077c55 100644 --- a/planning/obstacle_stop_planner/config/plot_juggler_adaptive_cruise.xml +++ b/planning/obstacle_stop_planner/config/plot_juggler_adaptive_cruise.xml @@ -102,14 +102,14 @@ - + - + @@ -121,11 +121,11 @@ - + - + diff --git a/planning/obstacle_stop_planner/config/plot_juggler_slow_down.xml b/planning/obstacle_stop_planner/config/plot_juggler_slow_down.xml index cbb840b12552a..92b56c2d2e6e4 100644 --- a/planning/obstacle_stop_planner/config/plot_juggler_slow_down.xml +++ b/planning/obstacle_stop_planner/config/plot_juggler_slow_down.xml @@ -57,13 +57,13 @@ - + - + @@ -81,11 +81,11 @@ - + - + diff --git a/planning/planning_validator/config/planning_validator_plotjugler_config.xml b/planning/planning_validator/config/planning_validator_plotjugler_config.xml index d331ed9985dfc..d6afc0b017d32 100644 --- a/planning/planning_validator/config/planning_validator_plotjugler_config.xml +++ b/planning/planning_validator/config/planning_validator_plotjugler_config.xml @@ -120,13 +120,13 @@ - + - + @@ -140,15 +140,15 @@ - + - + - + diff --git a/sensing/pointcloud_preprocessor/config/processing_time_ms.xml b/sensing/pointcloud_preprocessor/config/processing_time_ms.xml index 5da1ec3720fb0..569e2e34df670 100644 --- a/sensing/pointcloud_preprocessor/config/processing_time_ms.xml +++ b/sensing/pointcloud_preprocessor/config/processing_time_ms.xml @@ -29,7 +29,7 @@ - + @@ -37,7 +37,7 @@ - + @@ -53,11 +53,11 @@ - + - + From 679c94b1bde7a023eea8155314c5597602526e98 Mon Sep 17 00:00:00 2001 From: Ambroise Vincent Date: Sun, 2 Jul 2023 22:21:38 +0200 Subject: [PATCH 2/2] ci: add JSON Schema validation (#4122) * ci: add JSON Schema validation Leverage the json-schema-check action from the autoware-github-actions repository. Issue-Id: SCM-6366 Signed-off-by: Ambroise Vincent Change-Id: I5f284e96b2eddc652a6da8c0338f92c411277c04 * Update .github/workflows/json-schema-check.yaml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> --------- Signed-off-by: Ambroise Vincent Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> --- .github/workflows/json-schema-check.yaml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 .github/workflows/json-schema-check.yaml diff --git a/.github/workflows/json-schema-check.yaml b/.github/workflows/json-schema-check.yaml new file mode 100644 index 0000000000000..3d0c0b83d8746 --- /dev/null +++ b/.github/workflows/json-schema-check.yaml @@ -0,0 +1,17 @@ +name: json-schema-check + +on: + pull_request: + paths: + - "**/schema/*.schema.json" + - "**/config/*.param.yaml" + +jobs: + json-schema-check: + runs-on: ubuntu-latest + steps: + - name: Check out repository + uses: actions/checkout@v3 + + - name: Run json-schema-check + uses: autowarefoundation/autoware-github-actions/json-schema-check@v1