From 4bfb753eb42d0f7954578954b62614314d05c6e7 Mon Sep 17 00:00:00 2001 From: Taekjin LEE Date: Thu, 12 Dec 2024 14:16:24 +0900 Subject: [PATCH] refactor(tier4_perception_launch): refactoring detection launchers (#9611) * feat: Update object detection launch files to include input and output arguments The object detection launch files have been updated to include input and output arguments for better flexibility and modularity. This allows for easier integration with other components and improves the overall performance of the system. ``` Signed-off-by: Taekjin LEE * feat: Update object detection launch files to include input and output arguments Signed-off-by: Taekjin LEE * refactor: Update object detection launch files for better readability Signed-off-by: Taekjin LEE * Update object detection launch files to include clustering output argument Signed-off-by: Taekjin LEE * fix: pass ns argument to the lidar_rule_detector Signed-off-by: Taekjin LEE * refactor: make euclidean_cluster not to use use_pointcloud_container and mark explicitly Signed-off-by: Taekjin LEE --------- Signed-off-by: Taekjin LEE --- .../detection/detection.launch.xml | 55 +++++++----- .../detector/camera_lidar_detector.launch.xml | 83 ++++++++++++------- .../detector/lidar_rule_detector.launch.xml | 25 ++++-- .../tracker_based_detector.launch.xml | 6 ++ .../launch/perception.launch.xml | 2 +- 5 files changed, 112 insertions(+), 59 deletions(-) diff --git a/launch/tier4_perception_launch/launch/object_recognition/detection/detection.launch.xml b/launch/tier4_perception_launch/launch/object_recognition/detection/detection.launch.xml index 499cf3c192164..912a7f3e48f41 100644 --- a/launch/tier4_perception_launch/launch/object_recognition/detection/detection.launch.xml +++ b/launch/tier4_perception_launch/launch/object_recognition/detection/detection.launch.xml @@ -47,37 +47,40 @@ - + - - - - - - - - - + + + + + + + + + + + + - - - - - - + + + + + + - - - + + + - - - - + + + + @@ -129,6 +132,7 @@ + @@ -159,6 +163,7 @@ + @@ -182,9 +187,11 @@ + + @@ -217,6 +224,8 @@ + + diff --git a/launch/tier4_perception_launch/launch/object_recognition/detection/detector/camera_lidar_detector.launch.xml b/launch/tier4_perception_launch/launch/object_recognition/detection/detector/camera_lidar_detector.launch.xml index e06682853d956..da30500070850 100644 --- a/launch/tier4_perception_launch/launch/object_recognition/detection/detector/camera_lidar_detector.launch.xml +++ b/launch/tier4_perception_launch/launch/object_recognition/detection/detector/camera_lidar_detector.launch.xml @@ -1,5 +1,8 @@ + + + @@ -41,6 +44,35 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - + + @@ -110,14 +142,11 @@ - - - - - - + + + @@ -151,8 +180,8 @@ - - + + @@ -161,21 +190,21 @@ - - - + + + + - - + + - @@ -207,8 +236,8 @@ - - + + @@ -216,24 +245,22 @@ - - + + - - - - + + - - + + diff --git a/launch/tier4_perception_launch/launch/object_recognition/detection/detector/lidar_rule_detector.launch.xml b/launch/tier4_perception_launch/launch/object_recognition/detection/detector/lidar_rule_detector.launch.xml index 76ed8ad5b2700..50cde24473d2c 100644 --- a/launch/tier4_perception_launch/launch/object_recognition/detection/detector/lidar_rule_detector.launch.xml +++ b/launch/tier4_perception_launch/launch/object_recognition/detection/detector/lidar_rule_detector.launch.xml @@ -1,20 +1,31 @@ + + + + + + + + + + + + - - + + - @@ -22,16 +33,16 @@ - - + + - - + + diff --git a/launch/tier4_perception_launch/launch/object_recognition/detection/detector/tracker_based_detector.launch.xml b/launch/tier4_perception_launch/launch/object_recognition/detection/detector/tracker_based_detector.launch.xml index 754542f65b0ba..286bd43a8cc1e 100644 --- a/launch/tier4_perception_launch/launch/object_recognition/detection/detector/tracker_based_detector.launch.xml +++ b/launch/tier4_perception_launch/launch/object_recognition/detection/detector/tracker_based_detector.launch.xml @@ -1,11 +1,17 @@ + + + + + + diff --git a/launch/tier4_perception_launch/launch/perception.launch.xml b/launch/tier4_perception_launch/launch/perception.launch.xml index 83c7c202e8c0a..02a34eab8fe9a 100644 --- a/launch/tier4_perception_launch/launch/perception.launch.xml +++ b/launch/tier4_perception_launch/launch/perception.launch.xml @@ -77,7 +77,7 @@ - +