Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pycbc_fit_sngls_by_template can be made more efficient, I think #4565

Open
GarethCabournDavies opened this issue Nov 9, 2023 · 1 comment
Open

pycbc_fit_sngls_by_template can be made more efficient, I think #4565

GarethCabournDavies opened this issue Nov 9, 2023 · 1 comment
Assignees
@GarethCabournDavies
Labels
offline search

Comments

@GarethCabournDavies
Copy link
Contributor

With the changes in #4545, pycbc_fit_sngls_by_template should be able to use the SingleDetTriggers directly (I think)

However some of the datasets will use all triggers, whereas others use all above the ranking statistic of interest, so this needs to be handled carefully / sensibly / with more time than I have right now.
@GarethCabournDavies
Copy link
Contributor Author

The get_stat function does seem to do this already. So maybe this isn't needed

@GarethCabournDavies GarethCabournDavies self-assigned this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GarethCabournDavies GarethCabournDavies

Labels
offline search
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GarethCabournDavies