Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in utils.py #32

Closed
SarchB opened this issue Oct 27, 2020 · 1 comment
Closed

Error in utils.py #32

SarchB opened this issue Oct 27, 2020 · 1 comment

Comments

@SarchB
Copy link

SarchB commented Oct 27, 2020

Sorry, should probably not raise an issue but rather submit a commit, but don't work with girhub often and short on time.

But I found that coin_id = coin_link.values()[0].lstrip("/currencies/")[:-1] in utils.py should be changed to coin_id = coin_link.values()[0].replace("/currencies/","")[:-1]

I discovered it while running into trouble trying to use your code for currency EOS.

I found that '/currencies/eos' in your code resulted in 'os' as the coin_id, while it should be 'eos'. I thought it was a bug in Python but found it wasn't > https://bugs.python.org/issue5318

@guptarohit
Copy link
Owner

@SarchB, Thanks for raising the issue, fixed in new release 🎉 please update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants