Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature proposals: non-social mode, contact form #36

Closed
tompenzer opened this issue Jun 9, 2018 · 3 comments
Closed

Feature proposals: non-social mode, contact form #36

tompenzer opened this issue Jun 9, 2018 · 3 comments

Comments

@tompenzer
Copy link
Contributor

tompenzer commented Jun 9, 2018

Hi Guillaume,

In modifying this project for my personal uses, a couple features seem like they might be appealing to users of the project for relatively little effort:

  1. Add a .env variable for SOCIAL_FEATURES=true, and if you set it to false, self-registration routes are disabled, and commenting and liking are no longer rendered to the views or queried in the controllers. I've hard-coded most of those changes in my fork, but it would be relatively straightforward to add conditionality where needed keyed off the .env and make that a configuration option.

  2. I've added a (fully localized) lightweight implementation of a contact form, implemented with a new 'Can be contacted' role assigned to users you want to appear in a recipient selector on the contact page if there are more than one user with the role. Upon submission, the form's post contents get emailed out to the corresponding user's email. Optionally, in my fork, I've also replaced the 'email' displayed on user profiles with a 'title' string column I added to the users table (in addition to a 'blurb' text column, and a media_id integer foreign key reference to a media gallery item for a profile pic), but an alternative might be to put a link to contact.user, $user there (a separate route for contacting a particular recipient, i.e. /contact/user/1). I say lightweight because the contact form submissions are neither stored in the DB, nor managed in the admin dashboard. They just get emailed right out and that's it.

I'd be happy to contribute these features if you'd be interested, though I'm ashamed to say I can't figure out how to submit a PR, since I can't make branches.

@tompenzer
Copy link
Contributor Author

Oh wait, I guess I can fork it for that PR, and set that fork as the source for the PR... that must be how you do it. Lemme know if you're interested.

@guillaumebriday
Copy link
Owner

Hey ! Thank you so much for your contributions, I saw your fork, it's great !

This features could be very useful indeed but I don't think they belong to this project because the main purpose of this repo is to show how to use the framework features. This features seem to add complexity for non technical purpose.

I hope you understand, Thanks ! 👌

@tompenzer
Copy link
Contributor Author

tompenzer commented Jun 13, 2018

Gotcha, understood. I've been very impressed with the work you've done to put this project together using this modern tech stack in such an elegant way. Since the project is the first result on google when you search for "laravel blog", and it's so close to a deploy-and-go solution, I thought you might possibly be providing an answer to those looking for something like Wordpress or Drupal, minus all the cruft and with a beautiful Laravel foundation. Maybe I'm overestimating the market for people willing to learn [enough about] Laravel for deploying a blog[, but not enough to make the proposed changes].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants