Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prout to know when PRs are deployed or overdue #465

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

rtyley
Copy link
Member

@rtyley rtyley commented Mar 20, 2024

Adds Prout, to let us know when our changes don't ship as expected, or when they are ready to check in Production!

Some other recents PRs enabling Prout on repos:

Adds https://github.com/guardian/prout, to let us know when our changes don't ship as expected, or
when they are ready to see in Production!

Some other recents PRs enabling Prout on repos:

* guardian/permissions#174
* guardian/dotcom-rendering#9692

https://www.theguardian.com/info/developer-blog/2015/feb/03/prout-is-your-pull-request-out
Comment on lines +3 to +4
"Checker": { "url": "https://checker.typerighter.gutools.co.uk/healthcheck", "overdue": "15M" },
"Rule Manager": { "url": "https://manager.typerighter.gutools.co.uk/healthcheck", "overdue": "15M" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These urls both have the advantage of not requiring authentication, so that Prout can reach them easily to get the git commit id.

@rtyley rtyley changed the title Add Prout to know when PRs are deployed- or overdue Add Prout to know when PRs are deployed or overdue Mar 20, 2024
@rtyley rtyley marked this pull request as ready for review March 20, 2024 17:38
@rtyley rtyley requested a review from a team as a code owner March 20, 2024 17:38
Copy link
Contributor

@jonathonherbert jonathonherbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! Thanks, @rtyley.

@rtyley rtyley merged commit 232e17f into main Mar 20, 2024
1 check passed
@rtyley rtyley deleted the add-prout branch March 20, 2024 17:58
@prout-bot
Copy link

Seen on Rule Manager (merged by @rtyley 28 minutes and 9 seconds ago) Please check your changes!

@prout-bot
Copy link

Overdue on Checker (merged by @rtyley 28 minutes and 9 seconds ago) What's gone wrong?

rtyley added a commit to guardian/tagmanager that referenced this pull request Aug 7, 2024
Adds [Prout](https://www.theguardian.com/info/developer-blog/2015/feb/03/prout-is-your-pull-request-out),
to let us know when our changes don't ship as expected, or when they are ready to check in Production!

This PR uses guardian/permissions#174 as a recent example of
adding Prout, other examples include:

* guardian/typerighter#465
* guardian/dotcom-rendering#9692
rtyley added a commit to guardian/tagmanager that referenced this pull request Sep 10, 2024
Adds [Prout](https://www.theguardian.com/info/developer-blog/2015/feb/03/prout-is-your-pull-request-out),
to let us know when our changes don't ship as expected, or when they are ready to check in Production!

This PR uses guardian/permissions#174 as a recent example of
adding Prout, other examples include:

* guardian/typerighter#465
* guardian/dotcom-rendering#9692
rtyley added a commit to guardian/tagmanager that referenced this pull request Sep 10, 2024
Adds [Prout](https://www.theguardian.com/info/developer-blog/2015/feb/03/prout-is-your-pull-request-out),
to let us know when our changes don't ship as expected, or when they are ready to check in Production!

This PR uses guardian/permissions#174 as a recent example of
adding Prout, other examples include:

* guardian/typerighter#465
* guardian/dotcom-rendering#9692
rtyley added a commit to guardian/tagmanager that referenced this pull request Sep 10, 2024
Adds [Prout](https://www.theguardian.com/info/developer-blog/2015/feb/03/prout-is-your-pull-request-out),
to let us know when our changes don't ship as expected, or when they are ready to check in Production!

This PR uses guardian/permissions#174 as a recent example of
adding Prout, other examples include:

* guardian/typerighter#465
* guardian/dotcom-rendering#9692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants