Add CloudFront certificate #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in an upcoming CloudFront distribution. It requires its own yaml and CI step because it must be in us-east-1, while the rest of our project is in eu-west-1. Its ARN will be used as a parameter in the main cloudfront yaml
224e619 to
0dee697
Compare
0dee697 to
b9ec490
Compare
59a2293 to
e6775eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to: #515
What does this change?
This PR adds a CloudFront certificate to Tagmanager, to be used in a follow-up PR. Once merged, the ARN for the certificate will be added to Parameter Store and used as part of the CloudFormation for a CloudFront Distribution.
This requires its own RiffRaff project (
tag-manager-certificates) and CI step because it must be in theus-east-1region, while the rest of the project is ineu-west-1.How to test
Deploy to CODE, as I have done here. If the deploy succeeds, the CloudFormation is valid.