Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to add description to spreadsheet tool #514

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

itsibitzi
Copy link
Contributor

What does this change?

Adds description field to spreadsheet search.

How to test

Do a search on it

@Fweddi
Copy link

Fweddi commented Jun 19, 2024

After approving I noticed this for some descriptions - but might be a useful message:
image

@itsibitzi
Copy link
Contributor Author

description is an optional field that not all tags have. You can make the spreadsheet tool load an empty query which just returns everything, which I guess is what's happening here. It looks weird cos it doesn't relate to your query. I think this is a bug, separate to the PR that could be addressed when someone gets the time to properly investigate.

@itsibitzi itsibitzi merged commit b089b93 into main Jun 20, 2024
1 check passed
@itsibitzi itsibitzi deleted the sc-20240619-spreadsheet-description branch June 20, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants