Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AAP World bucket #162

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Add AAP World bucket #162

merged 1 commit into from
Feb 21, 2025

Conversation

sb-dev
Copy link
Contributor

@sb-dev sb-dev commented Feb 19, 2025

What does this change?

Subject codes

Subject codes do not follow the standard format and require processing during ingestion. For example:

["06000000+environmental", "issue|04000000+economy,", "business", "and", "finance|04006006+insurance|03000000+disaster", "accident|06011000+global", "warming"]

These codes are extracted as IPTC NewsCodes.

AAP World bucket implementation

  • All sport subject codes are excluded from the bucket.

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

@sb-dev sb-dev requested a review from a team as a code owner February 19, 2025 09:52
Copy link
Contributor

@bryophyta bryophyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍 I've left a comment about formatting the subject codes

@sb-dev sb-dev force-pushed the aap-world branch 2 times, most recently from ea06e05 to 48651c5 Compare February 20, 2025 11:33
@sb-dev sb-dev merged commit 6847b26 into main Feb 21, 2025
3 checks passed
@sb-dev sb-dev deleted the aap-world branch February 21, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants