Add prout to DCR #9692
Merged
Add prout to DCR #9692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 730 kB ℹ️ View Unchanged
|
7ef48e2 to
609e3c9
Compare
cemms1
commented
Nov 29, 2023
Closed
609e3c9 to
ee2f531
Compare
cemms1
commented
Dec 5, 2023
| @@ -213,7 +217,7 @@ https://workforus.theguardian.com/careers/product-engineering/ | |||
| } | |||
| ${ | |||
| renderingTarget === 'Web' | |||
| ? `<meta name="theme-color" content="${brandBackground.primary}" />` | |||
| ? `<meta name="theme-color" content="${sourcePalette.brand[400]}" />` | |||
There was a problem hiding this comment.
[non-related change]
brandBackground is deprecated so replacing with the equivalent colour in the non-deprecated palette
cemms1
commented
Dec 5, 2023
| @@ -196,6 +197,9 @@ https://workforus.theguardian.com/careers/product-engineering/ | |||
| ? weAreHiringMessage | |||
| : '<!-- Hello there, HTML enthusiast! -->' | |||
| } | |||
|
|
|||
| <!-- DCR commit hash ${GIT_COMMIT_HASH} --> | |||
There was a problem hiding this comment.
Commit hash is directly embedded in the HTML
There was a problem hiding this comment.
Yep, embedding the commit directly into the body of the response is always best, if you can, for making sure that Prout reflects what users are really seeing!
cemms1
commented
Dec 5, 2023
Comment on lines
+7
to
+10
| "CODE": { | ||
| "url": "https://m.code.dev-theguardian.com/uk", | ||
| "overdue": "30M" | ||
| } |
There was a problem hiding this comment.
Added CODE URL for monitoring initially but plan to remove later
ee2f531 to
28c9b78
Compare
28c9b78 to
1a29667
Compare
rtyley
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Brilliant stuff!
Remember, the diagnostic page at https://prout-bot.herokuapp.com/view/guardian/dotcom-rendering will give helpful info once the PR is merged!
| @@ -196,6 +197,9 @@ https://workforus.theguardian.com/careers/product-engineering/ | |||
| ? weAreHiringMessage | |||
| : '<!-- Hello there, HTML enthusiast! -->' | |||
| } | |||
|
|
|||
| <!-- DCR commit hash ${GIT_COMMIT_HASH} --> | |||
There was a problem hiding this comment.
Yep, embedding the commit directly into the body of the response is always best, if you can, for making sure that Prout reflects what users are really seeing!
| "overdue": "30M" | ||
| }, | ||
| "CODE": { | ||
| "url": "https://m.code.dev-theguardian.com/uk", |
There was a problem hiding this comment.
Incidentally, have you deployed this to CODE? Did you see the hash?
There was a problem hiding this comment.
Yep! Good news
https://m.code.dev-theguardian.com/uk?dcr does indeed show the commit hash corresponding to https://riffraff.gutools.co.uk/deployment/view/59010e8b-f34c-4f4f-9297-47a68aadf2bc
There was a problem hiding this comment.
So I guess I can remove this CODE endpoint now 🥳
There was a problem hiding this comment.
I'll do this in a separate PR though ^ (I've waited around for checks to pass on this one for too long 😄 )
There was a problem hiding this comment.
https://m.code.dev-theguardian.com/uk?dcr does indeed show the commit hash corresponding to https://riffraff.gutools.co.uk/deployment/view/59010e8b-f34c-4f4f-9297-47a68aadf2bc
Ah yeah, I see it!
rtyley
added a commit
to guardian/typerighter
that referenced
this pull request
Mar 20, 2024
Adds https://github.com/guardian/prout, to let us know when our changes don't ship as expected, or when they are ready to see in Production! Some other recents PRs enabling Prout on repos: * guardian/permissions#174 * guardian/dotcom-rendering#9692 https://www.theguardian.com/info/developer-blog/2015/feb/03/prout-is-your-pull-request-out
rtyley
added a commit
to guardian/tagmanager
that referenced
this pull request
Aug 7, 2024
Adds [Prout](https://www.theguardian.com/info/developer-blog/2015/feb/03/prout-is-your-pull-request-out), to let us know when our changes don't ship as expected, or when they are ready to check in Production! This PR uses guardian/permissions#174 as a recent example of adding Prout, other examples include: * guardian/typerighter#465 * guardian/dotcom-rendering#9692
rtyley
added a commit
to guardian/tagmanager
that referenced
this pull request
Sep 10, 2024
Adds [Prout](https://www.theguardian.com/info/developer-blog/2015/feb/03/prout-is-your-pull-request-out), to let us know when our changes don't ship as expected, or when they are ready to check in Production! This PR uses guardian/permissions#174 as a recent example of adding Prout, other examples include: * guardian/typerighter#465 * guardian/dotcom-rendering#9692
rtyley
added a commit
to guardian/tagmanager
that referenced
this pull request
Sep 10, 2024
Adds [Prout](https://www.theguardian.com/info/developer-blog/2015/feb/03/prout-is-your-pull-request-out), to let us know when our changes don't ship as expected, or when they are ready to check in Production! This PR uses guardian/permissions#174 as a recent example of adding Prout, other examples include: * guardian/typerighter#465 * guardian/dotcom-rendering#9692
rtyley
added a commit
to guardian/tagmanager
that referenced
this pull request
Sep 10, 2024
Adds [Prout](https://www.theguardian.com/info/developer-blog/2015/feb/03/prout-is-your-pull-request-out), to let us know when our changes don't ship as expected, or when they are ready to check in Production! This PR uses guardian/permissions#174 as a recent example of adding Prout, other examples include: * guardian/typerighter#465 * guardian/dotcom-rendering#9692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds prout config to DCR so that developers can know when their commits are in a production environment.
This PR is linked with #26721It should not need an additional
frontendPRWhy?
Speeds up development and allows devs better visibility of when their work has reached prod.
A possible precursor to allowing merge queues in this repo