-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update highlights trails fixture to use article format enums #13118
Conversation
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Size Change: 0 B Total Size: 870 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💎
Seen on PROD (merged by @jamesmockett 8 minutes and 49 seconds ago) Please check your changes! |
What does this change?
Updates fixture to use exported
ArticleFormat
enum constants rather than hardcoding the underlying numeric values.Why?
Using the numeric values means an incorrect format may be used if the enums are updated. Adding a new constant will change the position and numeric value of existing constants. This has recently occurred when a new constant was adding to the
ArticleDesign
enum, breaking a number of Storybook stories which use this fixture.