From 28c9b78c30c743f768442a83ca946b4afc3e0a6e Mon Sep 17 00:00:00 2001 From: Charlotte Date: Tue, 5 Dec 2023 14:01:02 +0000 Subject: [PATCH] embed commit hash directly in html instead of separate endpoint --- dotcom-rendering/.prout.json | 6 +++++- dotcom-rendering/src/server/htmlPageTemplate.ts | 8 ++++++-- dotcom-rendering/src/server/server.prod.ts | 5 ----- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/dotcom-rendering/.prout.json b/dotcom-rendering/.prout.json index 26265e9c8f8..193fbcc266e 100644 --- a/dotcom-rendering/.prout.json +++ b/dotcom-rendering/.prout.json @@ -1,7 +1,11 @@ { "checkpoints": { "PROD": { - "url": "https://www.theguardian.com/prout-dcr", + "url": "https://www.theguardian.com/uk", + "overdue": "30M" + }, + "CODE": { + "url": "https://m.code.dev-theguardian.com/uk", "overdue": "30M" } } diff --git a/dotcom-rendering/src/server/htmlPageTemplate.ts b/dotcom-rendering/src/server/htmlPageTemplate.ts index 8e84b7b4dd5..604cbe5d7af 100644 --- a/dotcom-rendering/src/server/htmlPageTemplate.ts +++ b/dotcom-rendering/src/server/htmlPageTemplate.ts @@ -1,4 +1,4 @@ -import { brandBackground, resets } from '@guardian/source-foundations'; +import { resets, palette as sourcePalette } from '@guardian/source-foundations'; import he from 'he'; import { ASSET_ORIGIN } from '../lib/assets'; import { escapeData } from '../lib/escapeData'; @@ -6,6 +6,7 @@ import { getFontsCss } from '../lib/fonts-css'; import { getHttp3Url } from '../lib/getHttp3Url'; import type { Guardian } from '../model/guardian'; import type { RenderingTarget } from '../types/renderingTarget'; +import { GIT_COMMIT_HASH } from './prout'; type BaseProps = { css: string; @@ -196,6 +197,9 @@ https://workforus.theguardian.com/careers/product-engineering/ ? weAreHiringMessage : '' } + + + ${title} ${ @@ -213,7 +217,7 @@ https://workforus.theguardian.com/careers/product-engineering/ } ${ renderingTarget === 'Web' - ? `` + ? `` : `` } diff --git a/dotcom-rendering/src/server/server.prod.ts b/dotcom-rendering/src/server/server.prod.ts index 657bb93b5d6..dbb6e6e6a06 100644 --- a/dotcom-rendering/src/server/server.prod.ts +++ b/dotcom-rendering/src/server/server.prod.ts @@ -30,7 +30,6 @@ import { getContentFromURLMiddleware } from './lib/get-content-from-url'; import { logger } from './lib/logging'; import { requestLoggerMiddleware } from './lib/logging-middleware'; import { recordError } from './lib/logging-store'; -import { GIT_COMMIT_HASH } from './prout'; // Middleware to track route performance using 'response-time' lib // Usage: app.post('/Article', logRenderTime, renderArticle); @@ -55,10 +54,6 @@ export const prodServer = (): void => { res.status(200).send('OKAY'); }); - app.get('/_prout', (req: Request, res: Response) => { - res.status(200).send(GIT_COMMIT_HASH); - }); - // if running prod server locally, serve local assets if (!process.env.GU_PUBLIC) { app.use('/static/frontend', express.static(__dirname));