Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of content-entity and content-atom preview #246

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

Divs-B
Copy link
Contributor

@Divs-B Divs-B commented Mar 26, 2024

What does this change?

We are testing latest content-entity release after implementing gha-scala-release-process in it.
Since we bumped its version to content-atom and released its preview release hence umping that too to avoid semver version conflicts.
guardian/content-atom#169

How to test

Make preview release for this and will test in content-api-scala-client

@Divs-B Divs-B requested a review from a team as a code owner March 26, 2024 18:17
@gu-scala-library-release
Copy link
Contributor

@Divs-B has published a preview version of this PR with release workflow run #61, based on commit cbc6ec4:

23.0.0-PREVIEW.dbbump-and-test-content-entity-version.2024-03-27T0934.cbc6ec49

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the db/bump-and-test-content-entity-version branch, or use the GitHub CLI command:

gh workflow run release.yml --ref db/bump-and-test-content-entity-version

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

Copy link
Contributor

@emdash-ie emdash-ie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, go for it :)

@Divs-B Divs-B merged commit a73b56a into main Apr 12, 2024
1 check passed
@Divs-B
Copy link
Contributor Author

Divs-B commented Apr 23, 2024

This release is verified and tested.
Checked in content-api-scala-client:guardian/content-api-scala-client#415 and firehose-client:guardian/content-api-firehose-client#46 which at the end tested in one of client using all that is apple-news:https://github.com/guardian/apple-news/pull/331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants