Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup-sbt to workflow #10

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

codingWithRach
Copy link
Contributor

@codingWithRach codingWithRach commented Oct 30, 2024

What does this change?

Adds setup-sbt to workflow

Note that scala-setup was not used due to a discrepancy between the java-version in setup-java, and that in the pre-existing .tool-versions file

How to test

Workflow ran successfully on this branch

How can we measure success?

No more failing workflows

Have we considered potential risks?

Images

Accessibility

Copy link

Test Results

2 files  ±0  2 suites  ±0   0s ⏱️ ±0s
2 tests ±0  2 ✅ ±0  0 💤 ±0  0 ❌ ±0 
4 runs  ±0  4 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0b08901. ± Comparison against base commit 3004a76.

@codingWithRach codingWithRach marked this pull request as ready for review October 30, 2024 11:15
@codingWithRach codingWithRach requested a review from a team as a code owner October 30, 2024 11:15
Copy link
Member

@JustinPinner JustinPinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@emdash-ie emdash-ie merged commit 1ad7cac into main Nov 11, 2024
2 checks passed
@emdash-ie emdash-ie deleted the rachel/add-setup-scala-to-workflow branch November 11, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants