-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compressed size action #1813
Conversation
|
Ad load time test resultsFor Test conditions:
|
Size Change: -4 B (0%) Total Size: 213 kB ℹ️ View Unchanged
|
a2db44c
to
7112343
Compare
7112343
to
4cb3e89
Compare
47580e6
to
9b6c0ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks useful to me! Nice
Seen on PROD (merged by @emma-imber 1 minute and 50 seconds ago) Please check your changes! |
What does this change?
Adds the compressed size action to pull request workflows.
Why?
We've recently made some changes that have reduced the bundle size (eg. removing unused Prebid adapters) and this action will give us immediate feedback on future PRs to help quantify the impact of a change on the bundle size.
Example
I temporarily downgraded the Prebid version to 9.27.0 on this branch, and the compressed size action showed that doing that resulted in an increase in bundle size, as the previous version includes extra adapters.