Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compressed size action #1813

Merged
merged 10 commits into from
Feb 25, 2025
Merged

Add compressed size action #1813

merged 10 commits into from
Feb 25, 2025

Conversation

emma-imber
Copy link
Contributor

@emma-imber emma-imber commented Feb 21, 2025

What does this change?

Adds the compressed size action to pull request workflows.

Why?

We've recently made some changes that have reduced the bundle size (eg. removing unused Prebid adapters) and this action will give us immediate feedback on future PRs to help quantify the impact of a change on the bundle size.

Example

I temporarily downgraded the Prebid version to 9.27.0 on this branch, and the compressed size action showed that doing that resulted in an increase in bundle size, as the previous version includes extra adapters.

Screenshot 2025-02-21 at 16 25 54

Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: 9b6c0ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 21, 2025

Ad load time test results

For consented, top-above-nav took on average 4325ms to load.
For consentless, top-above-nav took on average 3089ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

Copy link
Contributor

github-actions bot commented Feb 21, 2025

Size Change: -4 B (0%)

Total Size: 213 kB

ℹ️ View Unchanged
Filename Size Change
dist/prod/artifacts/commercial/********************/graun.699.commercial.js 3.48 kB 0 B
dist/prod/artifacts/commercial/********************/graun.679.commercial.js 4.36 kB 0 B
dist/prod/artifacts/commercial/********************/graun.ad-free.commercial.js 4.47 kB +1 B (+0.02%)
dist/prod/artifacts/commercial/********************/graun.Prebid.js.commercial.js 135 kB 0 B
dist/prod/artifacts/commercial/********************/graun.consentless-advertising.commercial.js 1.9 kB 0 B
dist/prod/artifacts/commercial/********************/graun.884.commercial.js 28.1 kB 0 B
dist/prod/artifacts/commercial/********************/graun.220.commercial.js 231 B 0 B
dist/prod/artifacts/commercial/********************/graun.consented-advertising.commercial.js 15.4 kB -1 B (-0.01%)
dist/prod/artifacts/commercial/********************/graun.standalone.commercial.js 12.9 kB -4 B (-0.03%)
dist/prod/artifacts/commercial/********************/graun.760.commercial.js 6.98 kB 0 B

compressed-size-action

@emma-imber emma-imber force-pushed the ei/compressed-size-action branch from a2db44c to 7112343 Compare February 21, 2025 12:37
@emma-imber emma-imber force-pushed the ei/compressed-size-action branch from 7112343 to 4cb3e89 Compare February 21, 2025 12:43
@emma-imber emma-imber force-pushed the ei/compressed-size-action branch from 47580e6 to 9b6c0ae Compare February 21, 2025 16:26
@emma-imber emma-imber marked this pull request as ready for review February 21, 2025 16:31
@emma-imber emma-imber requested a review from a team as a code owner February 21, 2025 16:31
Copy link
Member

@Jakeii Jakeii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks useful to me! Nice

@emma-imber emma-imber merged commit d8f20d7 into main Feb 25, 2025
28 checks passed
@emma-imber emma-imber deleted the ei/compressed-size-action branch February 25, 2025 10:53
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @emma-imber 1 minute and 50 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants