Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve E2E testing of prebid #1811

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Improve E2E testing of prebid #1811

merged 3 commits into from
Feb 25, 2025

Conversation

Jakeii
Copy link
Member

@Jakeii Jakeii commented Feb 20, 2025

What does this change?

Expand our e2e tests to better verify prebid is running correctly.

checks include:

  • That the prebid.js script is loaded
  • That bids are requested for our bidders
  • That no bidderErrors occur, excluding timeouts as these are fairly common and unlikely to be because of our own code.

Why?

Confidence when making changes to prebid

Copy link

changeset-bot bot commented Feb 20, 2025

⚠️ No Changeset found

Latest commit: cdff9cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 20, 2025

Ad load time test results

For consented, top-above-nav took on average 4343ms to load.
For consentless, top-above-nav took on average 3111ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@Jakeii Jakeii force-pushed the jlk/prebid-e2e-test branch from 4dfbcf6 to cb67bcf Compare February 24, 2025 10:11
@Jakeii Jakeii marked this pull request as ready for review February 24, 2025 10:55
@Jakeii Jakeii requested a review from a team as a code owner February 24, 2025 10:55
Comment on lines +59 to +70
expect(bidders).toHaveLength(10);
[
'oxd',
'and',
'pubmatic',
'ix',
'adyoulike',
'ozone',
'xhb',
'criteo',
'ttd',
'rubicon',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to specific this is UK, to avoid issues for US/AUS IPs?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a better question. Do we want to consider AUS/US?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future travellers, we discussed in standup and will cover this in our canaries as we don't have multi-region testing in our CI.

Copy link
Member

@arelra arelra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see these tests expanded, nice work! ✨

@Jakeii Jakeii merged commit 0ab472d into main Feb 25, 2025
14 checks passed
@Jakeii Jakeii deleted the jlk/prebid-e2e-test branch February 25, 2025 10:48
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @Jakeii 1 minute and 46 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants