-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve E2E testing of prebid #1811
Conversation
|
Ad load time test resultsFor Test conditions:
|
4dfbcf6
to
cb67bcf
Compare
expect(bidders).toHaveLength(10); | ||
[ | ||
'oxd', | ||
'and', | ||
'pubmatic', | ||
'ix', | ||
'adyoulike', | ||
'ozone', | ||
'xhb', | ||
'criteo', | ||
'ttd', | ||
'rubicon', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to specific this is UK, to avoid issues for US/AUS IPs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a better question. Do we want to consider AUS/US?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future travellers, we discussed in standup and will cover this in our canaries as we don't have multi-region testing in our CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see these tests expanded, nice work! ✨
What does this change?
Expand our e2e tests to better verify prebid is running correctly.
checks include:
Why?
Confidence when making changes to prebid