Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the third party cookie detection iframe #1808

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Jakeii
Copy link
Member

@Jakeii Jakeii commented Feb 19, 2025

Why?

It's causing whitespace at the bottom of the page and it should not be visible!

@Jakeii Jakeii requested a review from a team as a code owner February 19, 2025 17:04
Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: c836e9e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Jakeii Jakeii changed the title hide the third party cookie detection iframe Hide the third party cookie detection iframe Feb 19, 2025
Copy link
Contributor

Ad load time test results

For consented, top-above-nav took on average 4305ms to load.
For consentless, top-above-nav took on average 3931ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@Jakeii Jakeii merged commit 6d25577 into main Feb 19, 2025
14 checks passed
@Jakeii Jakeii deleted the jlk/hide-third-party-cookie-iframe branch February 19, 2025 17:07
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @Jakeii 1 minute and 31 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants