-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the initPermutive call #1782
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
830dad8
Move the initPermutive call
emma-imber eab043e
Make comment more useful
emma-imber c614118
Changeset
emma-imber 6aaa38f
Put change behind a 0% test
emma-imber 5f64c10
Update test dates
emma-imber 1bb0f30
Merge branch 'main' into ei/move-initPermutive
emma-imber 83f9875
Add console log for testing
emma-imber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@guardian/commercial': minor | ||
--- | ||
|
||
Move the initPermutive call so that the googletag script can be loaded a little earlier |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import type { ABTest } from '@guardian/ab-core'; | ||
|
||
export const movePermutiveSegmentation: ABTest = { | ||
id: 'MovePermutiveSegmentation', | ||
author: '@commercial-dev', | ||
start: '2025-02-12', | ||
expiry: '2025-03-21', | ||
audience: 0 / 100, | ||
audienceOffset: 20 / 100, | ||
audienceCriteria: '', | ||
successMeasure: '', | ||
description: | ||
'Measure the performance impact of moving the initialisation of Permutive segmentation.', | ||
variants: [ | ||
{ | ||
id: 'control', | ||
test: (): void => { | ||
/* no-op */ | ||
}, | ||
}, | ||
{ | ||
id: 'variant', | ||
test: (): void => { | ||
/* no-op */ | ||
}, | ||
}, | ||
], | ||
canRun: () => true, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know its a 0% test, Wondered what this does
audienceOffset: 20 / 100
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The offset is to make sure that if we set it live (eg not 0%) that the test audience wouldn't overlap with that of your test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see great, Ill keep mine to 0/100 👍