Move the initPermutive call #1782
Conversation
🦋 Changeset detectedLatest commit: 83f9875 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ad load time test resultsFor Test conditions:
|
There was a problem hiding this comment.
This looks sensible to me, especially made clearer given the refactoring work you did in the PR: #1764
Would be interesting to see the metrics we can use to test (assuming in CODE as you mentioned?)
edf7ad3 to
c614118
Compare
| start: '2025-01-14', | ||
| expiry: '2025-02-28', | ||
| audience: 0 / 100, | ||
| audienceOffset: 20 / 100, |
There was a problem hiding this comment.
I know its a 0% test, Wondered what this does audienceOffset: 20 / 100
There was a problem hiding this comment.
The offset is to make sure that if we set it live (eg not 0%) that the test audience wouldn't overlap with that of your test
There was a problem hiding this comment.
Oh I see great, Ill keep mine to 0/100 👍
|
Seen on PROD (merged by @emma-imber 1 minute and 40 seconds ago) Please check your changes! |
What does this change?
Moves the
initPermutive()call fromconsented-advertisingto be a dependency offillStaticAdvertSlots, behind a 0% test. I've added a test offset of 20% to avoid the changes in this PRWhy?
At the moment,
initPermutive()has to happen beforeprepareGoogletag, so it blocks the loading of the googletag script. By moving it to be a dependency offillStaticAdvertSlots, we can load the googletag script a little earlier.The documentation states that the
initPermutive()code must run beforegoogletag.enableServices()is called.googletag.enableServices()is called bydisplayAdsanddisplayLazyAds, both of which are only called byfillStaticAdvertSlots, so as long as initPermutive runs before that, we should be all good.