Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more regional prebid #1765

Merged
merged 2 commits into from
Jan 29, 2025
Merged

No more regional prebid #1765

merged 2 commits into from
Jan 29, 2025

Conversation

emma-imber
Copy link
Contributor

What does this change?

Reverses the change in this PR that introduced the use of regional versions of prebid.

Why?

AB testing has shown no statistically significant benefit of splitting prebid by region to ad speed or viewability, so we're putting the code back to how it was.

@emma-imber emma-imber requested a review from a team as a code owner January 27, 2025 16:46
Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: a760024

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Ad load time test results

For consented, top-above-nav took on average 4406ms to load.
For consentless, top-above-nav took on average 3134ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@emma-imber emma-imber merged commit 9bc278c into main Jan 29, 2025
14 checks passed
@emma-imber emma-imber deleted the ei/no-regional-prebid branch January 29, 2025 10:41
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @emma-imber 1 minute and 51 seconds ago) Please check your changes!

@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @emma-imber 1 minute and 52 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants