Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip liveblog-ad-limit test #1685

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

arelra
Copy link
Member

@arelra arelra commented Nov 26, 2024

What does this change?

Update liveblog-ad-limit e2e test to reduce flakiness.

On inspection it looks like its possible for window.mockLiveUpdate to be undefined until the Liveness island is hydrated and the function is set on the window.

Adding a wait on window.mockLiveUpdate to be defined should remove this corner case.

@arelra arelra requested a review from a team as a code owner November 26, 2024 16:08
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 45bca89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Ad load time test results

For consented, top-above-nav took on average 5530ms to load.
For consentless, top-above-nav took on average 3269ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

Copy link
Contributor

@deedeeh deedeeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad we won't have that issue anymore. Thank you Ravi for doing it ✨

@arelra arelra merged commit a446fff into main Nov 27, 2024
13 checks passed
@arelra arelra deleted the ravi/fix-flakey-liveblog-e2e-test branch November 27, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants