Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds manual gpid to prebid ad unit and launch to 99% of users #1651

Merged
merged 13 commits into from
Nov 20, 2024

Conversation

dskamiotis
Copy link
Contributor

@dskamiotis dskamiotis commented Nov 8, 2024

What does this change?

The GPID is being added to enable the successful sending of GPID to prebid vendors. This implementation uses the GPT Pre-Auction module, as recommended by the Prebid Docs if your project is using GAM/GPT.

Why?

We are adding the GPID to prebid as part of the OpenRTB framework, there isa field in the impressionExtension object called imp.ext.gpid. This will allow uis to conform to the protocol by sending a standardised GPID across all SPP's.
The Guardian’s ad server (GAM) to Prebid needs to follow certain standards to ensure that Prebid can interpret the information correctly and that all exchanges involved in the auction can handle and propagate it.

This includes:

  • updating the PrebidAdUnit class to include a method to dynamically generate a GPID for each ad unit

  • using the Unique ad slots method outlined in the docs:

  • Including the GPID to 99% of users - users in variant with shouldIncludeGpid

pbjs.addAdUnits({
    code: '/1111/homepage-leftnav',
    ortb2Imp: {
        ext: {
            gpid: "/1111/homepage-leftnav",
        data: {
                pbadslot: "/1111/homepage-leftnav"
            }
        }
    },
    mediaTypes: ...
    bids: ...
});
  • Added Testing - 1% control and 1% variant
  • Control - continues usuing existing protocol data structure
  • Variant - adds the new structure:
ortb2Imp: {
        ext: {
            gpid: "/1111/homepage-leftnav",
        data: {
                pbadslot: "/1111/homepage-leftnav"
            }
        }
OpenRTB in professor prebid - Control - #ab-gpidPrebid=control
Screenshot 2024-11-14 at 09 33 43
OpenRTB in professor prebid - Variant - #ab-gpidPrebid=variant
Screenshot 2024-11-08 at 21 23 44

Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: c88a7b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Ad load time test results

For consented, top-above-nav took on average 5426ms to load.
For consentless, top-above-nav took on average 3012ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@dskamiotis dskamiotis marked this pull request as ready for review November 8, 2024 15:51
@dskamiotis dskamiotis requested a review from a team as a code owner November 8, 2024 15:51
@dskamiotis dskamiotis force-pushed the ds/add-gpid-to-prebid branch from 60d74a3 to c2c2a43 Compare November 8, 2024 15:59
@dskamiotis dskamiotis force-pushed the ds/add-gpid-to-prebid branch 2 times, most recently from d7ff89b to edc8997 Compare November 14, 2024 09:38
@dskamiotis dskamiotis changed the title adds manual gpid to prebid ad unit adds manual gpid to prebid ad unit and launch to 99% of users Nov 18, 2024
@dskamiotis dskamiotis requested review from emma-imber, Jakeii and a team November 18, 2024 09:27
@dskamiotis dskamiotis force-pushed the ds/add-gpid-to-prebid branch from 61acfac to f016daf Compare November 20, 2024 10:27
@dskamiotis dskamiotis requested review from Jakeii, a team and SiAdcock November 20, 2024 10:27
@dskamiotis dskamiotis force-pushed the ds/add-gpid-to-prebid branch from f016daf to e2eab02 Compare November 20, 2024 15:11
Co-authored-by: Emma Imber <108270776+emma-imber@users.noreply.github.com>
@dskamiotis dskamiotis merged commit 9fa6e7d into main Nov 20, 2024
13 checks passed
@dskamiotis dskamiotis deleted the ds/add-gpid-to-prebid branch November 20, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants