-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds manual gpid to prebid ad unit and launch to 99% of users #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c88a7b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ad load time test resultsFor Test conditions:
|
60d74a3
to
c2c2a43
Compare
Jakeii
reviewed
Nov 11, 2024
Jakeii
reviewed
Nov 11, 2024
d7ff89b
to
edc8997
Compare
emma-imber
reviewed
Nov 14, 2024
7 tasks
Jakeii
reviewed
Nov 19, 2024
61acfac
to
f016daf
Compare
f016daf
to
e2eab02
Compare
emma-imber
reviewed
Nov 20, 2024
Co-authored-by: Emma Imber <108270776+emma-imber@users.noreply.github.com>
emma-imber
reviewed
Nov 20, 2024
emma-imber
approved these changes
Nov 20, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The GPID is being added to enable the successful sending of GPID to prebid vendors. This implementation uses the GPT Pre-Auction module, as recommended by the Prebid Docs if your project is using GAM/GPT.
Why?
We are adding the GPID to prebid as part of the OpenRTB framework, there isa field in the impressionExtension object called imp.ext.gpid. This will allow uis to conform to the protocol by sending a standardised GPID across all SPP's.
The Guardian’s ad server (GAM) to Prebid needs to follow certain standards to ensure that Prebid can interpret the information correctly and that all exchanges involved in the auction can handle and propagate it.
This includes:
updating the
PrebidAdUnit
class to include a method to dynamically generate a GPID for each ad unitusing the
Unique ad slots
method outlined in the docs:Including the GPID to 99% of users - users in variant with
shouldIncludeGpid
#ab-gpidPrebid=control
#ab-gpidPrebid=variant