Merge branch 'main' into ei/move-initPermutive

guardian · Feb 5, 2025 · edf7ad3 · edf7ad3
2 parents ce230ed + cac500b
commit edf7ad3
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 37 deletions.
diff --git a/.changeset/olive-bees-think.md b/.changeset/olive-bees-think.md
@@ -0,0 +1,5 @@
+---
+'@guardian/commercial': minor
+---
+
+Remove 0% test for The Trade Desk and set live
diff --git a/src/experiments/ab-tests.ts b/src/experiments/ab-tests.ts
@@ -2,7 +2,6 @@ import type { ABTest } from '@guardian/ab-core';
 import { mpuWhenNoEpic } from './tests/mpu-when-no-epic';
 import { optOutFrequencyCap } from './tests/opt-out-frequency-cap';
 import { prebidKeywords } from './tests/prebid-keywords';
-import { ttdPrebidBidder } from './tests/ttd-prebid';
 
 /**
  * You only need to add tests to this file if the code you are testing is here in
@@ -14,5 +13,4 @@ export const concurrentTests: ABTest[] = [
 	mpuWhenNoEpic,
 	optOutFrequencyCap,
 	prebidKeywords,
-	ttdPrebidBidder,
 ];
diff --git a/src/experiments/tests/ttd-prebid.ts b/src/experiments/tests/ttd-prebid.ts
diff --git a/src/lib/header-bidding/prebid/bid-config.ts b/src/lib/header-bidding/prebid/bid-config.ts
@@ -47,7 +47,6 @@ import {
 	shouldIncludeKargo,
 	shouldIncludeMagnite,
 	shouldIncludeOpenx,
-	shouldIncludeTheTradeDesk,
 	shouldIncludeTripleLift,
 	shouldIncludeTrustX,
 	shouldIncludeXaxis,
@@ -684,7 +683,7 @@ const currentBidders = (
 		[shouldIncludeOpenx(), openxClientSideBidder(pageTargeting)],
 		[shouldIncludeKargo(), kargoBidder],
 		[shouldIncludeMagnite(), magniteBidder],
-		[shouldIncludeTheTradeDesk(), theTradeDeskBidder(gpid)],
+		[true, theTradeDeskBidder(gpid)],
 	];
 
 	const otherBidders = biddersToCheck

diff --git a/src/lib/header-bidding/utils.ts b/src/lib/header-bidding/utils.ts
@@ -1,7 +1,5 @@
 import { isString } from '@guardian/libs';
 import { once } from 'lodash-es';
-import { isUserInVariant } from '../../experiments/ab';
-import { ttdPrebidBidder } from '../../experiments/tests/ttd-prebid';
 import { createAdSize } from '../../lib/ad-sizes';
 import {
 	isInAuOrNz,
@@ -191,9 +189,6 @@ export const shouldIncludeKargo = (): boolean => isInUsa();
 export const shouldIncludeMagnite = (): boolean =>
 	!!window.guardian.config.switches.prebidMagnite;
 
-export const shouldIncludeTheTradeDesk = (): boolean =>
-	isUserInVariant(ttdPrebidBidder, 'variant');
-
 export const shouldIncludeMobileSticky = once(
 	(): boolean =>
 		window.location.hash.includes('#mobile-sticky') ||