Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote @mrizzi to "Reviewer" #1310

Closed
jeffmendoza opened this issue Sep 22, 2023 · 9 comments · Fixed by #1327
Closed

Promote @mrizzi to "Reviewer" #1310

jeffmendoza opened this issue Sep 22, 2023 · 9 comments · Fixed by #1327
Labels
question Further information is requested

Comments

@jeffmendoza
Copy link
Member

Looking at the Contributor Ladder

Reviewer Review contributions from other members Prove technical expertise in at least one GUAC topic area Can approve PRs Write

Once a community participant has demonstrated expertise in one GUAC topic area, owners and/on maintainers can propose graduating the community participant to the next role, that of Reviewer.
A reviewer will be responsible of reviewing contributions from other contributors that touch the corresponding topic area. They should ensure that the PRs are adequately tested, follow the guidelines for the specific topic area.

We propose promoting @mrizzi to the level of "Reviewer". Marco has shown expertise in the area of "Backends" (ent), and has agreed to the above responsibilities of the level.

This issue is serving as that proposal for approval consensus.
cc @mlieberman85 @mihaimaruseac @lumjjb @pxp928 @SantiagoTorres @rgreinho @jeffmendoza

@jeffmendoza jeffmendoza added the question Further information is requested label Sep 22, 2023
@mihaimaruseac
Copy link
Collaborator

LGTM

@lumjjb
Copy link
Contributor

lumjjb commented Sep 22, 2023

LGTM!

1 similar comment
@pxp928
Copy link
Collaborator

pxp928 commented Sep 22, 2023

LGTM!

@dejanb
Copy link
Contributor

dejanb commented Sep 22, 2023

+1 (non-binding)

@lumjjb
Copy link
Contributor

lumjjb commented Sep 25, 2023

@mlieberman85
Copy link
Collaborator

LGTM!

1 similar comment
@jeffmendoza
Copy link
Member Author

LGTM!

@jeffmendoza
Copy link
Member Author

@mrizzi Congrats, the majority has voted you in! We don't have a list anywhere for Reviewers. Can you add one with yourself? Probably at the end of the CONTRIBUTING.md makes sense.

Also, I've opened #1323 to clarify that the vote for Reviewers is the same as Owners.

@mrizzi mrizzi mentioned this issue Sep 27, 2023
6 tasks
@mrizzi
Copy link
Collaborator

mrizzi commented Sep 27, 2023

@mrizzi Congrats, the majority has voted you in! We don't have a list anywhere for Reviewers.

Thanks a lot everyone, really happy for this 🎉

Can you add one with yourself? Probably at the end of the CONTRIBUTING.md makes sense.

Sure! Done in #1327

Also, I've opened #1323 to clarify that the vote for Reviewers is the same as Owners.

@kodiakhq kodiakhq bot closed this as completed in #1327 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants