Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme Clearing Previously Set CSS Variables #13

Closed
dfreeman06 opened this issue May 20, 2021 · 2 comments · Fixed by #14
Closed

Theme Clearing Previously Set CSS Variables #13

dfreeman06 opened this issue May 20, 2021 · 2 comments · Fixed by #14

Comments

@dfreeman06
Copy link

It looks like the GT themes here are clearing out previously set css variables. For example in https://github.com/jupyrdf/ipyelk/blob/master/style/diagram.css#L10 those variables no longer exist when using the GT COAR Dark or GT COAR Light themes.
@dfreeman06
Copy link
Author

dfreeman06 commented May 20, 2021 •
edited
Loading

Base Jupyter light theme:
image

Using GT COAR Light Theme;
image

@nrbgt nrbgt mentioned this issue Jun 28, 2021
Merged
6 tasks
@dfreeman06
Copy link
Author

The edge css isnt coming through on the GT dark:
image

@nrbgt nrbgt closed this as completed in #14 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split packages nrbgt/jupyterlab-gt-coar-theme
1 participant
@dfreeman06