Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge awsNuke and awsDefaults Logics #651

Closed
james03160927 opened this issue Mar 11, 2024 · 3 comments · Fixed by #686
Closed

Merge awsNuke and awsDefaults Logics #651

james03160927 opened this issue Mar 11, 2024 · 3 comments · Fixed by #686
Assignees
@james03160927
Labels
cloud-nuke enhancement New feature or request

Comments

@james03160927
Copy link
Contributor

Context/Background

Right now, you will notice that we have separate routes for awsNuke and awsDefaults:

  • awsDefaults: nuking default VPCs
  • awsNuke: nuking other resources

However, there seems to be quite a lot of changes we can merge and streamline.

  • ec2.go file currently contains nuking operations for a lot of resources (e.g., internet gateway, subnet, route tables). Let's separate it out to individual resources.
  • we support functionality on individual resources to support nuking default vs. non-default resources
  • we make changes in awsDefaults to follow similar logic as awsNuke to nuke default resources.
  • we deprecate awsDefaults and create a parameter or config in awsNuke to target default resources.
@james03160927 james03160927 self-assigned this Mar 18, 2024
@james03160927 james03160927 added cloud-nuke enhancement New feature or request labels Mar 18, 2024 — with Linear
@Hrushi20
Copy link

Hrushi20 commented Apr 1, 2024

Hey! Can I work on this issue?

@james03160927
Copy link
Contributor Author

HI @Hrushi20, I'm actually working on this change!

@Hrushi20
Copy link

Hrushi20 commented Apr 2, 2024

Are there any issues I can work on?

@james03160927 james03160927 mentioned this issue Apr 5, 2024
Merged
5 tasks
@james03160927 james03160927 mentioned this issue Apr 19, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@james03160927 james03160927

Labels
cloud-nuke enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Nuke Implementation for EC2 Resources. gruntwork-io/cloud-nuke
2 participants
@Hrushi20 @james03160927