Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throughput: AbstractServerStream does unnecessary flushes #331

Closed
louiscryan opened this issue Apr 23, 2015 · 3 comments
Closed

Throughput: AbstractServerStream does unnecessary flushes #331

louiscryan opened this issue Apr 23, 2015 · 3 comments
Labels
performance

Comments

@louiscryan
Copy link
Contributor

@ejona86 @nmittler

  1. AbstractServerStream.writeMessage if no headers have been sent will immediately flush an empty header to the transport, by triggering internalSendFrame(flush = true)
  2. In the case of a unary response we don't delay the flush of the framed message to allow the trailers to be flushed at the same time.

Will work on a PR
@nmittler
Copy link
Member

@louiscryan sgtm ... good find!

@ejona86
Copy link
Member

ejona86 commented Apr 23, 2015

#274 manually introduces the optimized flush behavior to OkHttp (because it was missing the flush outright). It would be nice if we could tell the transport to flush or not, since we could even want to batch across RPCs.

This was referenced Apr 28, 2015
Closed
Closed
@louiscryan louiscryan mentioned this issue Apr 30, 2015
Closed
@louiscryan
Copy link
Contributor Author

This has been resolved by

#431

@lock lock bot locked as resolved and limited conversation to collaborators Sep 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ejona86 @nmittler @louiscryan