Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.withDeadlineAfter(..) not working for us in 1.52.0 and above #10579

Closed
burk opened this issue Sep 28, 2023 · 2 comments
Closed

.withDeadlineAfter(..) not working for us in 1.52.0 and above #10579

burk opened this issue Sep 28, 2023 · 2 comments

Comments

@burk
Copy link

burk commented Sep 28, 2023

What version of gRPC-Java are you using?

1.51.3, 1.52.0 and 1.57.2

What is your environment?

Linux container in kubernetes in Google Cloud, Eclipse JDK 17

What did you expect to see?

We start up to 20 long-running gRPC requests concurrently, using a fixed thread pool. We use service.withDeadlineAfter(deadline.getSeconds(), TimeUnit.SECONDS) to time out the requests after 15 minutes. If the requests time out we split the work up into smaller requests.

In versions up to and including 1.51.3, this works fine. In versions 1.52.0 and above, the initial requests with the 15 minute deadline never time out.

What did you see instead?

Expected the requests to time out like before.

Steps to reproduce the bug

Please let me know any additional information I can provide.

Looking at the changelogs, it seems maybe this change could be related? #9626

@burk
Copy link
Author

burk commented Sep 28, 2023

Oh, maybe this is the same issue as this: #10336 ? I do think we have a general retry policy in place.

@ejona86
Copy link
Member

ejona86 commented Sep 28, 2023

Yeah, my first thought was #10336. I do know we looked into it more in the past month, but didn't find the direct cause.

I'm going to assume this a duplicate of #10336, as the more we investigate the easier it appears to be hit. If you happen to disable retries and it still happens, then comment here and we can reopen. But I do think it is a safe assumption it is the same issue.

CC @larry-safran

@ejona86 ejona86 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants