Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xdsclient: handle empty authority in new style resource names correctly #5487

Closed
easwars opened this issue Jul 8, 2022 · 0 comments · Fixed by #5488
Closed

xdsclient: handle empty authority in new style resource names correctly #5487

easwars opened this issue Jul 8, 2022 · 0 comments · Fixed by #5488
Labels
Type: Bug

Comments

@easwars
Copy link
Contributor

easwars commented Jul 8, 2022

Currently, the logic used to parse and regenerate resource names when using new style resource names is broken when the authority is empty.

grpc-go/xds/internal/xdsclient/xdsresource/name.go

Line 122 in 2c0949c

path = path + "/" + n.ID

For example, if a watch is registered for the following name xdstp:///type/id, the resource name being requested was getting set to xdstp://type/id. Note that type is now part of the authority of the requested URL.
@easwars easwars mentioned this issue Jul 8, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xdsclient: handle empty authority in new style resource names easwars/grpc-go
1 participant
@easwars