Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: Only the node id should be logged, not the full node #5392

Closed
ejona86 opened this issue Jun 2, 2022 · 0 comments · Fixed by #5461
Closed

xds: Only the node id should be logged, not the full node #5392

ejona86 opened this issue Jun 2, 2022 · 0 comments · Fixed by #5461
Assignees

Comments

@ejona86
Copy link
Member

ejona86 commented Jun 2, 2022

As seen in #5020 (comment):

2022/05/20 12:40:32 could not greet: rpc error: code = Unavailable desc = name resolver error: xds: ListenerResource target localhost:50051 not found, watcher timeout, xDS client nodeID: id:"projects/5/networks/default/nodes/fcee1e8b-301c-4cbe-adfd-44a694972a27" cluster:"cluster" metadata:{fields:{key:"INSTANCE_IP" value:{string_value:"10.0.2.100"}} fields:{key:"TRAFFICDIRECTOR_GCP_PROJECT_NUMBER" value:{string_value:"5"}} fields:{key:"TRAFFICDIRECTOR_NETWORK_NAME" value:{string_value:"default"}}} locality:{} user_agent_name:"gRPC Go" user_agent_version:"1.47.0-dev" client_features:"envoy.lb.does_not_support_overprovisioning" client_features:"xds.config.resource-in-sotw"

xds client was correctly updated to include the node id ("projects/5/networks/default/nodes/fcee1e8b-301c-4cbe-adfd-44a694972a27") in the error message, but it also includes all the other node information. That is a lot of noise and not what was designed.

@ejona86 ejona86 changed the title xds: Only the node _id_ should be logged, not the full node xds: Only the node id should be logged, not the full node Jun 2, 2022
@easwars easwars self-assigned this Jun 7, 2022
@easwars easwars added the P2 label Jun 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants