Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to HTTP2-grpc spec client should RST_STREAM if it receives END_STREAM before half closing #198

Closed
ejona86 opened this issue May 13, 2015 · 4 comments
Assignees

Comments

@ejona86
Copy link
Member

ejona86 commented May 13, 2015

No description provided.

@ejona86
Copy link
Member Author

ejona86 commented May 15, 2015

We may want to consider the implications of HTTP/2 §8.1:

An HTTP response is complete after the server sends - or the client receives - a frame with the END_STREAM flag set (including any CONTINUATION frames needed to complete a header block). A server can send a complete response prior to the client sending an entire request if the response does not depend on any portion of the request that has not been sent and received. When this is true, a server MAY request that the client abort transmission of a request without error by sending a RST_STREAM with an error code of NO_ERROR after sending a complete response (i.e., a frame with the END_STREAM flag). Clients MUST NOT discard responses as a result of receiving such a RST_STREAM, though clients can always discard responses at their discretion for other reasons.

I would totally believe we are doing that wrong today. It looks like it may be more appropriate to do it on the server-side since that is explicitly mentioned in the spec.

@ctiller
Copy link
Member

ctiller commented May 18, 2015

Almost certain that C is doing this wrong also.

@ctiller
Copy link
Member

ctiller commented May 19, 2015

Issued grpc/grpc#1661 to fix this for C core and associated wrapped languages.

@ejona86
Copy link
Member Author

ejona86 commented Sep 8, 2016

Java issues for client-side (grpc/grpc-java#2163) and server-side (grpc/grpc-java#2162)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants