-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Support HttpRule with field response" #730
Conversation
FYI @doroginin @johanbrandhorst @achew22 I will roll this back immediately because we can easily roll forward once it's not friday. |
@ivucica LGTM |
LGTM. Let's not break weekend hackers |
Alright, the change to googleapis/api-common-protos has been merged already! Looks like someone "just" needs to regenerate code in |
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
=========================================
Coverage ? 56.29%
=========================================
Files ? 30
Lines ? 3121
Branches ? 0
=========================================
Hits ? 1757
Misses ? 1193
Partials ? 171
Continue to review full report at Codecov.
|
@ivucica I got in touch with @jadekler, he says this should be fixed? |
Looks like we can close this? |
Done |
Reverts #712
We should roll forward only once these blockers are resolved: