Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using FieldMasks with GET requests #698

Open
kibertoad opened this issue Jul 10, 2018 · 10 comments
Open

Support using FieldMasks with GET requests #698

kibertoad opened this issue Jul 10, 2018 · 10 comments

Comments

@kibertoad
Copy link

Some GET requests (e. g. search) benefit greatly from being able to distinguish between default (e. g. 0) and non-defined values, since searching by "name='John' && age = 0" is not the same as "name='John' && age = undefined".
Since FieldMasks are a generally recommended approach for optional fields in gRPC, it would be super helpful if grpc-gateway would support that.

@ivucica
Copy link
Collaborator

ivucica commented Aug 21, 2018

While it's recommended to use proto3 (so your FR makes sense), have you tried using proto2 syntax to distinguish between default and undefined values?

@johanbrandhorst
Copy link
Collaborator

This is being worked on in #671

@kibertoad
Copy link
Author

@johanbrandhorst Are you sure? There was explicit request to create a separate issue as implementation would have to be handled separately.

@johanbrandhorst
Copy link
Collaborator

How is your request different from that being implemented in #671? I apologize if I've misunderstood.

@kibertoad
Copy link
Author

#671 very explicitly handles specific case of "If a binding is mapped to PATCH [HTTP method]". This issue is about GET HTTP methods.

@johanbrandhorst
Copy link
Collaborator

Good spot, this'll have to be a separate PR then. Sorry for the misunderstanding.

@kibertoad
Copy link
Author

@johanbrandhorst Could you please remove "duplicate" label then :)?

@kibertoad
Copy link
Author

Ah, thanks, already done.

@negativeOne1
Copy link

negativeOne1 commented Sep 11, 2019

hey, just wanted to ask if there are any updates on this one? Could really use this feature.

@johanbrandhorst
Copy link
Collaborator

Be the change you want to see! What can I do to help you get this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants