-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using FieldMasks with GET requests #698
Comments
While it's recommended to use proto3 (so your FR makes sense), have you tried using proto2 syntax to distinguish between default and undefined values? |
This is being worked on in #671 |
@johanbrandhorst Are you sure? There was explicit request to create a separate issue as implementation would have to be handled separately. |
How is your request different from that being implemented in #671? I apologize if I've misunderstood. |
#671 very explicitly handles specific case of "If a binding is mapped to PATCH [HTTP method]". This issue is about GET HTTP methods. |
Good spot, this'll have to be a separate PR then. Sorry for the misunderstanding. |
@johanbrandhorst Could you please remove "duplicate" label then :)? |
Ah, thanks, already done. |
hey, just wanted to ask if there are any updates on this one? Could really use this feature. |
Be the change you want to see! What can I do to help you get this in? |
Some GET requests (e. g. search) benefit greatly from being able to distinguish between default (e. g. 0) and non-defined values, since searching by "name='John' && age = 0" is not the same as "name='John' && age = undefined".
Since FieldMasks are a generally recommended approach for optional fields in gRPC, it would be super helpful if grpc-gateway would support that.
The text was updated successfully, but these errors were encountered: