Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-portable filenames #93

Closed
sunshowers opened this issue Mar 21, 2015 · 3 comments
Closed

Non-portable filenames #93

sunshowers opened this issue Mar 21, 2015 · 3 comments

Comments

@sunshowers
Copy link

There are a bunch of filenames in the test suite that aren't portable across platforms. Specifically, filenames with colons in them are not supported on Windows.

Here's a list of files that aren't portable: https://gist.github.com/sid0/adbe8bbad152b6510102

It'd be great if you could rename them to something portable. Using an underscore maybe? Or maybe just turn them into subdirectories (groue/GRMustache) etc.
@groue groue closed this as completed in 7f3e079 Mar 22, 2015
@groue
Copy link
Owner

groue commented Mar 22, 2015

Hi @Sid0! I just pushed your suggested renaming. Is it OK for you now? Do you need a formal (tagged) release?

@sunshowers
Copy link
Author

Thanks. We don't need a formal release for this.

@groue
Copy link
Owner

groue commented Mar 23, 2015

Happy Mustache, then!

@sunshowers sunshowers mentioned this issue Mar 24, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@groue @sunshowers