Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate routes for all server URLs in OpenAPI spec #33

Open
sisp opened this issue Oct 10, 2020 · 0 comments
Open

Generate routes for all server URLs in OpenAPI spec #33

sisp opened this issue Oct 10, 2020 · 0 comments

Comments

@sisp
Copy link
Contributor

sisp commented Oct 10, 2020

Currently, only a single set of routes is generated based on the base path (the URL path of the first array element in the servers property of the OpenAPI spec) and the paths specified in the OpenAPI spec. I think it would be more consistent with the OpenAPI spec if routes for all array elements of the servers property were generated. If the servers property does not exist, then the base path falls back to / (same as now).

Taking this a bit further, I think also the scheme and hostname of the OpenAPI server object should be considered by the router when resolving routes, but I think Falcon currently doesn't support host-based routing.

What do you think @grktsh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant