Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLaplacianTests fail with Julia 1.7.3 #129

Open
principejavier opened this issue Sep 1, 2023 · 0 comments
Open

PLaplacianTests fail with Julia 1.7.3 #129

principejavier opened this issue Sep 1, 2023 · 0 comments

Comments

@principejavier
Copy link
Member

The error is ERROR: Scalar indexing on DebugArray is not allowed for performance reasons. and it occurs at this line

With Julia 1.9.3 it runs sucessfully

The reason for this behavior is the change in the implementation of copy!(dst::AbstractVector, src::AbstractVector) which indexed dst directly in v1.7.3, see here, whereas it calls copyto! in v1.9.3, see here

Possible solutions I see:

  1. increase compat
  2. implement copy! for DebugArray and MPIArray in PartitionedArrays.jl
  3. eliminate this overload which is not required after the this commit to PartitionedArrays.jl (although the test will fail with previous releases). I verified that copy(a::PSparseMatrix) and copy!(b::PSparseMatrix,a::PSparseMatrix) work with latest PartitonedArrays.jl.

@fverdugo , @amartinhuertas , @JordiManyer any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant