Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PermisoDialogFragment should extend android.support.v4.app.DialogFragment, not android.app.DialogFragment #13

Open
paulpv opened this issue May 5, 2016 · 0 comments
Open

PermisoDialogFragment should extend android.support.v4.app.DialogFragment, not android.app.DialogFragment #13

paulpv opened this issue May 5, 2016 · 0 comments

Comments

@paulpv
Copy link
Contributor

paulpv commented May 5, 2016

Admittedly, in 2016, the number of Android devices that don't support android.app.DialogFragment is getting very small, but to increase backwards compatibility PermisoDialogFragment should extend android.support.v4.app.DialogFragment instead of android.app.DialogFragment.

This would require changing "WeakReference mActivity" to either "WeakReference mActivity" or "WeakReference mActivity", which results in a few other required changes in the code.

Would you consider doing this, or a PR?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulpv