From afa53322c8dc445a9168df50e927de171aa4f582 Mon Sep 17 00:00:00 2001 From: Falco Duersch Date: Wed, 29 Apr 2020 09:50:40 +0200 Subject: [PATCH] Upgrade Jersey and disable test for now (#144) While a recent Jersey version provides "jakarta"-ified APIs, we are still unable to deploy it because Jersey depends on the javax.servlet classes internally (for instance in org.glassfish.jersey.servlet.ServletContainer). We'll have to wait for a compatible release of Jersey. --- integrationTests/helloJersey/build.gradle | 2 -- integrationTests/helloJersey/gradle.properties | 2 +- .../examples/gretty/hellojersey/RequestResponseSpec.groovy | 1 - .../org/akhikhl/examples/gretty/hellojersey/JerseyApp.java | 4 ++-- .../akhikhl/examples/gretty/hellojersey/TestResource.java | 6 +++--- integrationTests/settings.gradle | 4 +++- 6 files changed, 9 insertions(+), 10 deletions(-) diff --git a/integrationTests/helloJersey/build.gradle b/integrationTests/helloJersey/build.gradle index fccd03e34..e53532731 100644 --- a/integrationTests/helloJersey/build.gradle +++ b/integrationTests/helloJersey/build.gradle @@ -6,8 +6,6 @@ dependencies { compile "org.glassfish.jersey.containers:jersey-container-servlet-core:$jersey_version" compile "org.glassfish.jersey.inject:jersey-hk2:$jersey_version" compile 'javax.xml.bind:jaxb-api:2.3.1' - // FIXME - //integrationTestCompile "javax.servlet:servlet-api:$jetty7_servlet_api_version" } war { diff --git a/integrationTests/helloJersey/gradle.properties b/integrationTests/helloJersey/gradle.properties index 9e0d71f99..753c12242 100644 --- a/integrationTests/helloJersey/gradle.properties +++ b/integrationTests/helloJersey/gradle.properties @@ -1 +1 @@ -jersey_version=2.27 +jersey_version=3.0.0-M1 diff --git a/integrationTests/helloJersey/src/integrationTest/groovy/org/akhikhl/examples/gretty/hellojersey/RequestResponseSpec.groovy b/integrationTests/helloJersey/src/integrationTest/groovy/org/akhikhl/examples/gretty/hellojersey/RequestResponseSpec.groovy index fd4a2ee5f..ae2213b6e 100644 --- a/integrationTests/helloJersey/src/integrationTest/groovy/org/akhikhl/examples/gretty/hellojersey/RequestResponseSpec.groovy +++ b/integrationTests/helloJersey/src/integrationTest/groovy/org/akhikhl/examples/gretty/hellojersey/RequestResponseSpec.groovy @@ -11,7 +11,6 @@ package org.akhikhl.examples.gretty.hellojersey import org.akhikhl.gretty.GrettyAjaxSpec import static groovyx.net.http.ContentType.* import static groovyx.net.http.Method.* -import static javax.servlet.http.HttpServletResponse.* class RequestResponseSpec extends GrettyAjaxSpec { diff --git a/integrationTests/helloJersey/src/main/java/org/akhikhl/examples/gretty/hellojersey/JerseyApp.java b/integrationTests/helloJersey/src/main/java/org/akhikhl/examples/gretty/hellojersey/JerseyApp.java index 4daba7525..e0fa3b898 100644 --- a/integrationTests/helloJersey/src/main/java/org/akhikhl/examples/gretty/hellojersey/JerseyApp.java +++ b/integrationTests/helloJersey/src/main/java/org/akhikhl/examples/gretty/hellojersey/JerseyApp.java @@ -8,8 +8,8 @@ */ package org.akhikhl.examples.gretty.hellojersey; -import javax.ws.rs.ApplicationPath; -import javax.ws.rs.core.Application; +import jakarta.ws.rs.ApplicationPath; +import jakarta.ws.rs.core.Application; import java.util.HashSet; import java.util.Set; diff --git a/integrationTests/helloJersey/src/main/java/org/akhikhl/examples/gretty/hellojersey/TestResource.java b/integrationTests/helloJersey/src/main/java/org/akhikhl/examples/gretty/hellojersey/TestResource.java index 793e68505..b83b1c6ac 100644 --- a/integrationTests/helloJersey/src/main/java/org/akhikhl/examples/gretty/hellojersey/TestResource.java +++ b/integrationTests/helloJersey/src/main/java/org/akhikhl/examples/gretty/hellojersey/TestResource.java @@ -8,9 +8,9 @@ */ package org.akhikhl.examples.gretty.hellojersey; -import javax.ws.rs.GET; -import javax.ws.rs.Path; -import javax.ws.rs.Produces; +import jakarta.ws.rs.GET; +import jakarta.ws.rs.Path; +import jakarta.ws.rs.Produces; @Path("testresource") public class TestResource { diff --git a/integrationTests/settings.gradle b/integrationTests/settings.gradle index e4a67bf7f..aab5a88cf 100644 --- a/integrationTests/settings.gradle +++ b/integrationTests/settings.gradle @@ -2,7 +2,9 @@ rootProject.name = rootProjectName include 'helloGretty' include 'helloGrettySecure' include 'helloGrettyOverlay' -include 'helloJersey' +// FIXME waits for Jakarta release of Jersey (#163) +// Jersey 3.0.0-M1 still depends on javax.servlet internally +// include 'helloJersey' include 'extraResourceBases' include 'filterWebApp' include 'testAnnotations'