Data validation macro generalisation fix windows #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greole
added a commit
that referenced
this pull request
May 20, 2021
* add prefixed macro definition * Data validation macro generalisation fix windows (#2) * check if linebreak causes windows build to break * check if linebreak causes windows build to break * check if empty macro arg causes windows build to break * test if removing VA_ARGS resolves msvc error * test PASS_ON hack * Add missing PASS_ON * Add tests for complex values is_finite tests * Refactor macro expansion macro * Test if PASS_ON is needed when calling GKO_APPLY_MACRO * Refactor CALL_AND_RETURN_IF_CASTABLE macro * Moves GKO_CALL_FOR_... macros to types.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the MSVC builds