From 7a5aae1040c6010f1e79ba4aa73b29a76f0e3fa2 Mon Sep 17 00:00:00 2001
From: command-line <gregphiggins@gmail.com>
Date: Thu, 15 Feb 2024 07:55:34 +0000
Subject: [PATCH] tidy ames housing example

---
 .run/Example main.run.xml                     |  2 +-
 README.md                                     | 83 +++++++++++++++----
 .../example/AmesHousingCsvPipeline.java       | 54 ++++++++++++
 ...{HousingData.java => HouseSaleRecord.java} |  2 +-
 .../csvcompiler/example/MainTest.java         | 45 ----------
 5 files changed, 124 insertions(+), 62 deletions(-)
 create mode 100644 example/src/main/java/com/fluxtion/extension/csvcompiler/example/AmesHousingCsvPipeline.java
 rename example/src/main/java/com/fluxtion/extension/csvcompiler/example/{HousingData.java => HouseSaleRecord.java} (96%)
 delete mode 100644 example/src/main/java/com/fluxtion/extension/csvcompiler/example/MainTest.java

diff --git a/.run/Example main.run.xml b/.run/Example main.run.xml
index 61c8acd..dc3c2fe 100644
--- a/.run/Example main.run.xml	
+++ b/.run/Example main.run.xml	
@@ -1,6 +1,6 @@
 <component name="ProjectRunConfigurationManager">
   <configuration default="false" name="Example main" type="Application" factoryName="Application">
-    <option name="MAIN_CLASS_NAME" value="com.fluxtion.extension.csvcompiler.example.MainTest" />
+    <option name="MAIN_CLASS_NAME" value="com.fluxtion.extension.csvcompiler.example.AmesHousingCsvPipeline" />
     <module name="csv-compiler-example" />
     <option name="WORKING_DIRECTORY" value="$PROJECT_DIR$/example" />
     <extension name="coverage">
diff --git a/README.md b/README.md
index 82f8fb3..a96ed89 100644
--- a/README.md
+++ b/README.md
@@ -34,17 +34,18 @@ Supported features:
 - CSV compiler runtime: runtime library providing zerogc utilities and interface definitions
 
 ```xml
+
 <dependency>
     <dependency>
         <groupId>com.fluxtion.csv-compiler</groupId>
         <artifactId>csv-compiler</artifactId>
-        <version>1.0-SNAPSHOT</version>
+        <version>0.1.16</version>
     </dependency>
     <dependency>
         <groupId>com.fluxtion.csv-compiler</groupId>
         <artifactId>csv-compiler-processor</artifactId>
         <version>1.0-SNAPSHOT</version>
-        <scope>provided</scope>
+        <version>0.1.16</version>
     </dependency>
 </dependency>
 ```
@@ -64,14 +65,66 @@ This example loads a CSV file transforms it and writes the results to another CS
 - Derived value transforms a numerical value by an operation
 - The output is written to a new file excluding the input only columns
 
-Solving this problem requires two steps; firstly annotate a POJO's fields with ```@ColumnMapping```, secondly use the
-utility method [```RowMarshaller.transform()```](runtime/src/main/java/com/fluxtion/extension/csvcompiler/RowMarshaller.java#L159) to load the input file, transform/filter records with a
-java.util.stream.Stream
-and then finally write to an output file
+### Data sets
+
+We use the [ames housing from kaggle](https://www.kaggle.com/datasets/godofprogramming/ameshousing) as an input source,
+the source has 82 columns, spaces in headers, some field values are missing. The goal is to clean and transform this
+data
+set so it can be used in a machine learning model.
+
+A sample from the input data set:
+
+| Order | PID        | MS SubClass | MS Zoning | Lot Frontage | Lot Area | Street | Alley | Lot Shape | Land Contour | Utilities | Lot Config | Land Slope | Neighborhood | Condition 1 | Condition 2 | Bldg Type | House Style | Overall Qual | Overall Cond | Year Built | Year Remod/Add | Roof Style | Roof Matl | Exterior 1st | Exterior 2nd | Mas Vnr Type | Mas Vnr Area | Exter Qual | Exter Cond | Foundation | Bsmt Qual | Bsmt Cond | Bsmt Exposure | BsmtFin Type 1 | BsmtFin SF 1 | BsmtFin Type 2 | BsmtFin SF 2 | Bsmt Unf SF | Total Bsmt SF | Heating | Heating QC | Central Air | Electrical | 1st Flr SF | 2nd Flr SF | Low Qual Fin SF | Gr Liv Area | Bsmt Full Bath | Bsmt Half Bath | Full Bath | Half Bath | Bedroom AbvGr | Kitchen AbvGr | Kitchen Qual | TotRms AbvGrd | Functional | Fireplaces | Fireplace Qu | Garage Type | Garage Yr Blt | Garage Finish | Garage Cars | Garage Area | Garage Qual | Garage Cond | Paved Drive | Wood Deck SF | Open Porch SF | Enclosed Porch | 3Ssn Porch | Screen Porch | Pool Area | Pool QC | Fence | Misc Feature | Misc Val | Mo Sold | Yr Sold | Sale Type | Sale Condition | SalePrice |
+|:------|:-----------|:------------|:----------|:-------------|:---------|:-------|:------|:----------|:-------------|:----------|:-----------|:-----------|:-------------|:------------|:------------|:----------|:------------|:-------------|:-------------|:-----------|:---------------|:-----------|:----------|:-------------|:-------------|:-------------|:-------------|:-----------|:-----------|:-----------|:----------|:----------|:--------------|:---------------|:-------------|:---------------|:-------------|:------------|:--------------|:--------|:-----------|:------------|:-----------|:-----------|:-----------|:----------------|:------------|:---------------|:---------------|:----------|:----------|:--------------|:--------------|:-------------|:--------------|:-----------|:-----------|:-------------|:------------|:--------------|:--------------|:------------|:------------|:------------|:------------|:------------|:-------------|:--------------|:---------------|:-----------|:-------------|:----------|:--------|:------|:-------------|:---------|:--------|:--------|:----------|:---------------|:----------|
+| 1     | 0526301100 | 020         | RL        | 141          | 31770    | Pave   | NA    | IR1       | Lvl          | AllPub    | Corner     | Gtl        | NAmes        | Norm        | Norm        | 1Fam      | 1Story      | 6            | 5            | 1960       | 1960           | Hip        | CompShg   | BrkFace      | Plywood      | Stone        | 112          | TA         | TA         | CBlock     | TA        | Gd        | Gd            | BLQ            | 639          | Unf            | 0            | 441         | 1080          | GasA    | Fa         | Y           | SBrkr      | 1656       | 0          | 0               | 1656        | 1              | 0              | 1         | 0         | 3             | 1             | TA           | 7             | Typ        | 2          | Gd           | Attchd      | 1960          | Fin           | 2           | 528         | TA          | TA          | P           | 210          | 62            | 0              | 0          | 0            | 0         | NA      | NA    | NA           | 0        | 5       | 2010    | WD        | Normal         | 215000    |
+| 2     | 0526350040 | 020         | RH        | 80           | 11622    | Pave   | NA    | Reg       | Lvl          | AllPub    | Inside     | Gtl        | NAmes        | Feedr       | Norm        | 1Fam      | 1Story      | 5            | 6            | 1961       | 1961           | Gable      | CompShg   | VinylSd      | VinylSd      | None         | 0            | TA         | TA         | CBlock     | TA        | TA        | No            | Rec            | 468          | LwQ            | 144          | 270         | 882           | GasA    | TA         | Y           | SBrkr      | 896        | 0          | 0               | 896         | 0              | 0              | 1         | 0         | 2             | 1             | TA           | 5             | Typ        | 0          | NA           | Attchd      | 1961          | Unf           | 1           | 730         | TA          | TA          | Y           | 140          | 0             | 0              | 0          | 120          | 0         | NA      | MnPrv | NA           | 0        | 6       | 2010    | WD        | Normal         | 105000    |
+| 3     | 0526351010 | 020         | RL        | 81           | 14267    | Pave   | NA    | IR1       | Lvl          | AllPub    | Corner     | Gtl        | NAmes        | Norm        | Norm        | 1Fam      | 1Story      | 6            | 6            | 1958       | 1958           | Hip        | CompShg   | Wd Sdng      | Wd Sdng      | BrkFace      | 108          | TA         | TA         | CBlock     | TA        | TA        | No            | ALQ            | 923          | Unf            | 0            | 406         | 1329          | GasA    | TA         | Y           | SBrkr      | 1329       | 0          | 0               | 1329        | 0              | 0              | 1         | 1         | 3             | 1             | Gd           | 6             | Typ        | 0          | NA           | Attchd      | 1958          | Unf           | 1           | 312         | TA          | TA          | Y           | 393          | 36            | 0              | 0          | 0            | 0         | NA      | NA    | Gar2         | 12500    | 6       | 2010    | WD        | Normal         | 172000    |
+| 4     | 0526353030 | 020         | RL        | 93           | 11160    | Pave   | NA    | Reg       | Lvl          | AllPub    | Corner     | Gtl        | NAmes        | Norm        | Norm        | 1Fam      | 1Story      | 7            | 5            | 1968       | 1968           | Hip        | CompShg   | BrkFace      | BrkFace      | None         | 0            | Gd         | TA         | CBlock     | TA        | TA        | No            | ALQ            | 1065         | Unf            | 0            | 1045        | 2110          | GasA    | Ex         | Y           | SBrkr      | 2110       | 0          | 0               | 2110        | 1              | 0              | 2         | 1         | 3             | 1             | Ex           | 8             | Typ        | 2          | TA           | Attchd      | 1968          | Fin           | 2           | 522         | TA          | TA          | Y           | 0            | 0             | 0              | 0          | 0            | 0         | NA      | NA    | NA           | 0        | 4       | 2010    | WD        | Normal         | 244000    |
+| 5     | 0527105010 | 060         | RL        | 74           | 13830    | Pave   | NA    | IR1       | Lvl          | AllPub    | Inside     | Gtl        | Gilbert      | Norm        | Norm        | 1Fam      | 2Story      | 5            | 5            | 1997       | 1998           | Gable      | CompShg   | VinylSd      | VinylSd      | None         | 0            | TA         | TA         | PConc      | Gd        | TA        | No            | GLQ            | 791          | Unf            | 0            | 137         | 928           | GasA    | Gd         | Y           | SBrkr      | 928        | 701        | 0               | 1629        | 0              | 0              | 2         | 1         | 3             | 1             | TA           | 6             | Typ        | 1          | TA           | Attchd      | 1997          | Fin           | 2           | 482         | TA          | TA          | Y           | 212          | 34            | 0              | 0          | 0            | 0         | NA      | MnPrv | NA           | 0        | 3       | 2010    | WD        | Normal         | 189900    |
+| 6     | 0527105030 | 060         | RL        | 78           | 9978     | Pave   | NA    | IR1       | Lvl          | AllPub    | Inside     | Gtl        | Gilbert      | Norm        | Norm        | 1Fam      | 2Story      | 6            | 6            | 1998       | 1998           | Gable      | CompShg   | VinylSd      | VinylSd      | BrkFace      | 20           | TA         | TA         | PConc      | TA        | TA        | No            | GLQ            | 602          | Unf            | 0            | 324         | 926           | GasA    | Ex         | Y           | SBrkr      | 926        | 678        | 0               | 1604        | 0              | 0              | 2         | 1         | 3             | 1             | Gd           | 7             | Typ        | 1          | Gd           | Attchd      | 1998          | Fin           | 2           | 470         | TA          | TA          | Y           | 360          | 36            | 0              | 0          | 0            | 0         | NA      | NA    | NA           | 0        | 6       | 2010    | WD        | Normal         | 195500    |
+| 7     | 0527127150 | 120         | RL        | 41           | 4920     | Pave   | NA    | Reg       | Lvl          | AllPub    | Inside     | Gtl        | StoneBr      | Norm        | Norm        | TwnhsE    | 1Story      | 8            | 5            | 2001       | 2001           | Gable      | CompShg   | CemntBd      | CmentBd      | None         | 0            | Gd         | TA         | PConc      | Gd        | TA        | Mn            | GLQ            | 616          | Unf            | 0            | 722         | 1338          | GasA    | Ex         | Y           | SBrkr      | 1338       | 0          | 0               | 1338        | 1              | 0              | 2         | 0         | 2             | 1             | Gd           | 6             | Typ        | 0          | NA           | Attchd      | 2001          | Fin           | 2           | 582         | TA          | TA          | Y           | 0            | 0             | 170            | 0          | 0            | 0         | NA      | NA    | NA           | 0        | 4       | 2010    | WD        | Normal         | 213500    |
+| 8     | 0527145080 | 120         | RL        | 43           | 5005     | Pave   | NA    | IR1       | HLS          | AllPub    | Inside     | Gtl        | StoneBr      | Norm        | Norm        | TwnhsE    | 1Story      | 8            | 5            | 1992       | 1992           | Gable      | CompShg   | HdBoard      | HdBoard      | None         | 0            | Gd         | TA         | PConc      | Gd        | TA        | No            | ALQ            | 263          | Unf            | 0            | 1017        | 1280          | GasA    | Ex         | Y           | SBrkr      | 1280       | 0          | 0               | 1280        | 0              | 0              | 2         | 0         | 2             | 1             | Gd           | 5             | Typ        | 0          | NA           | Attchd      | 1992          | RFn           | 2           | 506         | TA          | TA          | Y           | 0            | 82            | 0              | 0          | 144          | 0         | NA      | NA    | NA           | 0        | 1       | 2010    | WD        | Normal         | 191500    |
+| 9     | 0527146030 | 120         | RL        | 39           | 5389     | Pave   | NA    | IR1       | Lvl          | AllPub    | Inside     | Gtl        | StoneBr      | Norm        | Norm        | TwnhsE    | 1Story      | 8            | 5            | 1995       | 1996           | Gable      | CompShg   | CemntBd      | CmentBd      | None         | 0            | Gd         | TA         | PConc      | Gd        | TA        | No            | GLQ            | 1180         | Unf            | 0            | 415         | 1595          | GasA    | Ex         | Y           | SBrkr      | 1616       | 0          | 0               | 1616        | 1              | 0              | 2         | 0         | 2             | 1             | Gd           | 5             | Typ        | 1          | TA           | Attchd      | 1995          | RFn           | 2           | 608         | TA          | TA          | Y           | 237          | 152           | 0              | 0          | 0            | 0         | NA      | NA    | NA           | 0        | 3       | 2010    | WD        | Normal         | 236500    |
+| 10    | 0527162130 | 060         | RL        | 60           | 7500     | Pave   | NA    | Reg       | Lvl          | AllPub    | Inside     | Gtl        | Gilbert      | Norm        | Norm        | 1Fam      | 2Story      | 7            | 5            | 1999       | 1999           | Gable      | CompShg   | VinylSd      | VinylSd      | None         | 0            | TA         | TA         | PConc      | TA        | TA        | No            | Unf            | 0            | Unf            | 0            | 994         | 994           | GasA    | Gd         | Y           | SBrkr      | 1028       | 776        | 0               | 1804        | 0              | 0              | 2         | 1         | 3             | 1             | Gd           | 7             | Typ        | 1          | TA           | Attchd      | 1999          | Fin           | 2           | 442         | TA          | TA          | Y           | 140          | 60            | 0              | 0          | 0            | 0         | NA      | NA    | NA           | 0        | 6       | 2010    | WD        | Normal         | 189000    |
+
+The post processed output data set should have:
+
+- a subset of the input columns
+- replace missing values such as Lot frontage with a default value.
+- calculate the Lot frontage squared
+- remove Lot frontage field from the output
+- convert MS Zoning from a text value to a numerical value stored in ms_zone_category field
+- remove MS Zoning field from the output
+- use fluent accessors to mirror property names, no get/set
+- filter rows from the output with missing Lot frontage
+- filter rows from the output that are not in a defined MS Zoning category set
+
+A sample output that should be generated
+
+| PID       | MS\_SubClass | Lot\_Frontage\_Squared | ms\_zone\_category |
+|:----------|:-------------|:-----------------------|:-------------------|
+| 526301100 | 20           | 19881                  | 3                  |
+| 526351010 | 20           | 6561                   | 3                  |
+| 526353030 | 20           | 8649                   | 3                  |
+| 527105010 | 60           | 5476                   | 3                  |
+| 527105030 | 60           | 6084                   | 3                  |
+| 527127150 | 120          | 1681                   | 3                  |
+| 527145080 | 120          | 1849                   | 3                  |
+| 527146030 | 120          | 1521                   | 3                  |
+| 527162130 | 60           | 3600                   | 3                  |
+| 527163010 | 60           | 5625                   | 3                  |
+
+Solving this problem requires two steps; firstly annotate a POJO's fields
+with [```@CsvMarshaller```](runtime/src/main/java/com/fluxtion/extension/csvcompiler/annotations/CsvMarshaller.java),
+secondly use the utility
+method [```RowMarshaller.transform()```](runtime/src/main/java/com/fluxtion/extension/csvcompiler/RowMarshaller.java#L159)
+that loads the input file, transforms/filters records with a
+java.util.stream.Stream and then finally writes records to an output file.
 
 ### Csv record file
 
-The [HousingData](example/src/main/java/com/fluxtion/extension/csvcompiler/example/HousingData.java) class represents
+The [HousingData](example/src/main/java/com/fluxtion/extension/csvcompiler/example/HouseSaleRecord.java) class
+represents
 the mapping of input, output and derived fields using annotations.
 The [```@CsvMarshaller```](runtime/src/main/java/com/fluxtion/extension/csvcompiler/annotations/CsvMarshaller.java)
 annotation is used in conjunction with lombok to generate a POJO that has fluent accessors, removing the need for
@@ -96,7 +149,7 @@ public class HouseSaleRecord {
     @ColumnMapping(columnName = "MS SubClass")
     private int MS_SubClass;
 
-    //derived no input field
+    //derived no inputs
     @ColumnMapping(optionalField = true)
     private int Lot_Frontage_Squared;
     @ColumnMapping(optionalField = true)
@@ -109,15 +162,16 @@ public class HouseSaleRecord {
 - Column names are mapped with ```@ColumnMapping(columnName = "MS SubClass")```
 - Default values are marked with ``` @ColumnMapping(defaultValue = "-1")```
 - Annotations can be
-  combined - ```@ColumnMapping(outputField = false, columnName = "Lot Frontage", defaultValue = "-1")``` 
+  combined - ```@ColumnMapping(outputField = false, columnName = "Lot Frontage", defaultValue = "-1")```
 
 ### CSV data pipeline
 
-The  [AimesHousingCsvPipeline](example/src/main/java/com/fluxtion/extension/csvcompiler/example/MainTest.java)  creates
-a csv data pipeline using the utility function from the [```RowMarshaller.transform()```](runtime/src/main/java/com/fluxtion/extension/csvcompiler/RowMarshaller.java#L159) class
+The  [AmesHousingCsvPipeline](example/src/main/java/com/fluxtion/extension/csvcompiler/example/AmesHousingCsvPipeline.java)
+creates a csv data pipeline using the utility function from the 
+[```RowMarshaller.transform()```](runtime/src/main/java/com/fluxtion/extension/csvcompiler/RowMarshaller.java#L159) class
 
 ```java
-public class AimesHousingCsvPipeline {
+public class AmesHousingCsvPipeline {
 
     @SneakyThrows
     public static void main(String[] args) {
@@ -125,8 +179,8 @@ public class AimesHousingCsvPipeline {
                 Path.of("data/AmesHousing.csv"),
                 Path.of("data/PostProcess.csv"),
                 s -> s.filter(record -> record.Lot_Frontage() > 0)
-                        .map(MainTest::squareLotFrontage)
-                        .map(MainTest::ms_zone_to_category)
+                        .map(AmesHousingCsvPipeline::squareLotFrontage)
+                        .map(AmesHousingCsvPipeline::ms_zone_to_category)
                         .filter(record -> record.ms_zone_category() > 0));
     }
 
@@ -149,7 +203,6 @@ public class AimesHousingCsvPipeline {
 }
 ```
 
-
 ## CSV to stream of bean instances
 
 This example converts csv -> bean -> process each bean record in a java stream. The example is
diff --git a/example/src/main/java/com/fluxtion/extension/csvcompiler/example/AmesHousingCsvPipeline.java b/example/src/main/java/com/fluxtion/extension/csvcompiler/example/AmesHousingCsvPipeline.java
new file mode 100644
index 0000000..e85c2bc
--- /dev/null
+++ b/example/src/main/java/com/fluxtion/extension/csvcompiler/example/AmesHousingCsvPipeline.java
@@ -0,0 +1,54 @@
+package com.fluxtion.extension.csvcompiler.example;
+
+import com.fluxtion.extension.csvcompiler.RowMarshaller;
+import lombok.SneakyThrows;
+
+import java.nio.file.Path;
+
+/**
+ * Utility to Transforms the https://www.kaggle.com/datasets/godofprogramming/ameshousing from 82 columns into an output csv with
+ * the following properties:
+ * <ul>
+ *     <li>a subset of the input columns</li>
+ *     <li>replace missing values such as Lot frontage with a default value</li>
+ *     <li>calculate the Lot frontage squared</li>
+ *     <li>remove Lot frontage field from the output</li>
+ *     <li>convert MS Zoning from a text value to a numerical value stored in ms_zone_category field</li>
+ *     <li>remove MS Zoning field from the output</li>
+ *     <li>use fluent accessors to mirror property names, no get/set</li>
+ *     <li>filter rows from the output with missing Lot frontage</li>
+ *     <li>filter rows from the output that are not in a defined MS Zoning category set</li>
+ * </ul>
+ *
+ * See {@link HouseSaleRecord} for the column definitions that maps fields
+ */
+public class AmesHousingCsvPipeline {
+
+    @SneakyThrows
+    public static void main(String[] args) {
+        RowMarshaller.load(HouseSaleRecord.class).transform(
+                Path.of("data/AmesHousing.csv"),
+                Path.of("data/PostProcess.csv"),
+                s -> s.filter(record -> record.Lot_Frontage() > 0)
+                        .map(AmesHousingCsvPipeline::squareLotFrontage)
+                        .map(AmesHousingCsvPipeline::ms_zone_to_category)
+                        .filter(record -> record.ms_zone_category() > 0));
+    }
+
+    public static HouseSaleRecord squareLotFrontage(HouseSaleRecord houseSaleRecord) {
+        int lotFrontage = houseSaleRecord.Lot_Frontage();
+        houseSaleRecord.Lot_Frontage_Squared(lotFrontage * lotFrontage);
+        return houseSaleRecord;
+    }
+
+    public static HouseSaleRecord ms_zone_to_category(HouseSaleRecord houseSaleRecord) {
+        switch (houseSaleRecord.MS_Zoning()) {
+            case "A" -> houseSaleRecord.ms_zone_category(1);
+            case "FV" -> houseSaleRecord.ms_zone_category(2);
+            case "RL" -> houseSaleRecord.ms_zone_category(3);
+            case "RM" -> houseSaleRecord.ms_zone_category(4);
+            default -> houseSaleRecord.ms_zone_category(-1);
+        }
+        return houseSaleRecord;
+    }
+}
diff --git a/example/src/main/java/com/fluxtion/extension/csvcompiler/example/HousingData.java b/example/src/main/java/com/fluxtion/extension/csvcompiler/example/HouseSaleRecord.java
similarity index 96%
rename from example/src/main/java/com/fluxtion/extension/csvcompiler/example/HousingData.java
rename to example/src/main/java/com/fluxtion/extension/csvcompiler/example/HouseSaleRecord.java
index 31d6348..ca8e45d 100644
--- a/example/src/main/java/com/fluxtion/extension/csvcompiler/example/HousingData.java
+++ b/example/src/main/java/com/fluxtion/extension/csvcompiler/example/HouseSaleRecord.java
@@ -8,7 +8,7 @@
 @Data
 @CsvMarshaller(fluent = true)
 @Accessors(fluent = true)
-public class HousingData {
+public class HouseSaleRecord {
     //input only
     @ColumnMapping(outputField = false)
     private int Order;
diff --git a/example/src/main/java/com/fluxtion/extension/csvcompiler/example/MainTest.java b/example/src/main/java/com/fluxtion/extension/csvcompiler/example/MainTest.java
deleted file mode 100644
index f594f27..0000000
--- a/example/src/main/java/com/fluxtion/extension/csvcompiler/example/MainTest.java
+++ /dev/null
@@ -1,45 +0,0 @@
-package com.fluxtion.extension.csvcompiler.example;
-
-import com.fluxtion.extension.csvcompiler.RowMarshaller;
-import lombok.SneakyThrows;
-
-import java.nio.file.Path;
-
-public class MainTest {
-
-    @SneakyThrows
-    public static void main(String[] args) {
-        RowMarshaller.load(HousingData.class).transform(
-                Path.of("data/AmesHousing.csv"),
-                Path.of("data/PostProcess.csv"),
-                s -> s.filter(MainTest::validFrontageValue)
-                        .map(MainTest::squareLotFrontage)
-                        .map(MainTest::ms_zone_to_category)
-                        .filter(MainTest::validZoneCategory));
-    }
-
-    public static HousingData squareLotFrontage(HousingData housingData) {
-        int lotFrontage = housingData.Lot_Frontage();
-        housingData.Lot_Frontage_Squared(lotFrontage * lotFrontage);
-        return housingData;
-    }
-
-    public static HousingData ms_zone_to_category(HousingData housingData) {
-        switch (housingData.MS_Zoning()) {
-            case "A" -> housingData.ms_zone_category(1);
-            case "FV" -> housingData.ms_zone_category(2);
-            case "RL" -> housingData.ms_zone_category(3);
-            case "RM" -> housingData.ms_zone_category(4);
-            default -> housingData.ms_zone_category(-1);
-        }
-        return housingData;
-    }
-
-    public static boolean validFrontageValue(HousingData h) {
-        return h.Lot_Frontage() > 0;
-    }
-
-    public static boolean validZoneCategory(HousingData h) {
-        return h.ms_zone_category() > 0;
-    }
-}