Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to fix mappings for 12 ISO codes in choropleth #603

Open
rando2 opened this issue Aug 14, 2020 · 0 comments
Open

Need to fix mappings for 12 ISO codes in choropleth #603

rando2 opened this issue Aug 14, 2020 · 0 comments
Assignees

Comments

@rando2
Copy link
Contributor

rando2 commented Aug 14, 2020

Is your feature request related to a problem? Please describe.
#569 generates maps showing clinical trial recruitment density by country. However, the ISO-to-map mappings treat certain geopolitical entities in sub-optimal ways (e.g., French Guiana shows up with the color assigned to France).
The codes handled this way are: 'LIE', 'MLT', 'GUF', 'SMR', 'HKG', 'GIB', 'BHR', 'MCO', 'UMI', 'IMN', 'SGP', 'MTQ'

Describe the solution you'd like
A clear and concise description of what you want to happen.
Looking at the Lowres dataset (which determines which regions of the map belong to each country), it should be possible to parse the multipolygon associated with a country like France, identify the part that describes French Guiana, and remove it from France + create a new row in the dataset. I haven't looked at the other countries, but presumably this is similar for all/most.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
We could ignore it since technically those are the correct ISO codes, but it detracts from the meaning of the figure and is questionable in a section where we're talking about issues with representation in clinicial trials.

Additional context
Add any other context or screenshots about the feature request here.

@rando2 rando2 self-assigned this Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant