Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Set the title and lead elements in the article component based solely on css selectors instead of directives #2848

Closed
Tracked by #1925
damienwebdev opened this issue Jun 13, 2024 · 0 comments · Fixed by #2887
Assignees
Labels
feat a new feature, enhancement, or improvement package: design @daffodil/design
Milestone

Comments

@damienwebdev
Copy link
Member

damienwebdev commented Jun 13, 2024

💡 Feature request

Feature Name

DaffArticleComponent should automatically set the title and lead elements based upon solely css selectors instead of directives

The Desired Behavior

The daffArticleTitle styles should apply to the daff-article h1 tag. The daffArticleLead should apply to the paragraph directly after the h1 tag in article.

Your Use Case

There is no easy way to add directives to markdown files, so we should just move the styles into the appropriate article tags.

Prior Work

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@damienwebdev damienwebdev added feat a new feature, enhancement, or improvement package: design @daffodil/design labels Jun 13, 2024
@xelaint xelaint changed the title DaffArticleComponent should automatically set the lead element based upon solely css selectors instead of directives [FEAT] DaffArticleComponent should automatically set the lead element based upon solely css selectors instead of directives Jun 13, 2024
@xelaint xelaint changed the title [FEAT] DaffArticleComponent should automatically set the lead element based upon solely css selectors instead of directives [FEAT] DaffArticleComponent should automatically set the title and lead elements based upon solely css selectors instead of directives Jun 13, 2024
@xelaint xelaint changed the title [FEAT] DaffArticleComponent should automatically set the title and lead elements based upon solely css selectors instead of directives [FEAT] Set the title and lead elements in the article component based solely on css selectors instead of directives Jun 13, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jun 13, 2024
@xelaint xelaint moved this from To do to In progress in The Design Library Jun 13, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in The Design Library Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat a new feature, enhancement, or improvement package: design @daffodil/design
Projects
2 participants