Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] URL should be included on package level nodes for docs generation #2719

Closed
Tracked by #1925 ...
xelaint opened this issue Jan 15, 2024 · 1 comment
Closed
Tracked by #1925 ...
Labels
bug A confirmed bug report docs This issue is related to documentation p1 critical priority package: daff.io @daffodil/daff.io
Milestone

Comments

@xelaint
Copy link
Member

xelaint commented Jan 15, 2024

🐛 Bug report

Current Behavior

Using main package URLs for the packages overview page. Noticed that packages with child markdown files have a url of /undefined

Expected Behavior

Include the URL on package level nodes.

Minimal reproduction of the problem with instructions

  1. navigate to next.daff.io/guides or next.daff.io/packages (depending on if certain PRs have been merged)
  2. Click on the @daffodil/cart card
  3. Should redirect to /404 because the route is /undefined
@xelaint xelaint changed the title Include the URL on package level nodes [BUG] [BUG] URL should be included on package level nodes for docs generation Jan 15, 2024
@xelaint xelaint added bug A confirmed bug report docs This issue is related to documentation labels Jan 15, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jan 15, 2024
@xelaint xelaint added p1 critical priority package: daff.io @daffodil/daff.io labels Jan 15, 2024
@xelaint xelaint mentioned this issue Jun 7, 2024
26 tasks
@damienwebdev
Copy link
Member

damienwebdev commented Jun 13, 2024

This appears corrected. On https://next.daff.io/docs/packages
image
works as expected and navigates you to https://next.daff.io/docs/packages/cart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed bug report docs This issue is related to documentation p1 critical priority package: daff.io @daffodil/daff.io
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants